Skip to content

[RFR] Readd new modules and mark the differences in module sets - #798

Merged
hbrunn merged 1 commit into
OCA:10.0from
StefanRijnhart:10.0-module_add_or_removed
May 9, 2017
Merged

[RFR] Readd new modules and mark the differences in module sets#798
hbrunn merged 1 commit into
OCA:10.0from
StefanRijnhart:10.0-module_add_or_removed

Conversation

@StefanRijnhart

@StefanRijnhart StefanRijnhart commented Apr 21, 2017

Copy link
Copy Markdown
Member

Follow up to the discussion from #795 about whether the module coverage list should feature the old modules from the previous release, the new modules from the new release, or both.

image

@StefanRijnhart
StefanRijnhart force-pushed the 10.0-module_add_or_removed branch from c7ea4b6 to 5a49c97 Compare April 21, 2017 18:41
@StefanRijnhart StefanRijnhart mentioned this pull request Apr 21, 2017
@pedrobaeza

Copy link
Copy Markdown
Member

This joins the best of both worlds, so I see this correct. Maybe now modules that are the same looks not correctly indented in the table. There are 3 possible solutions for this:

  • Put the icon in a new column.
  • Put a blank image with the same size of the other images.
  • Put the new/old image after the module name.


* 'Done' : Analyse has been done & work has been merged into trunk project ;

Modules that are new in this release are marked with |new|. Modules that are

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these icons to be correctly rendered as the definition is after?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no problem.

@StefanRijnhart

Copy link
Copy Markdown
Member Author

The placement is a matter of taste. None of the solutions are pretty. I tried adding the icon after the name, but I liked this better. This looks better when you look at the list in a browser tha it looks here in this screenshot, actually.

@pedrobaeza

Copy link
Copy Markdown
Member

OK, if you prefer this way, it's not the most important thing.

@pedrobaeza

Copy link
Copy Markdown
Member

There's still the question of renamed modules. I think here we have hr_equipment > maintenance.

@hbrunn

hbrunn commented May 9, 2017

Copy link
Copy Markdown
Member

for the renamed modules, I'd suggest a different PR. Merging this one

@hbrunn
hbrunn merged commit eb24cd8 into OCA:10.0 May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants