Nothing to do on these WEB_X modules - #799
Conversation
pedrobaeza
left a comment
There was a problem hiding this comment.
I have checked folders and run the script for looking for noupdate changes. One a little comment that I think it's important.
| |web_calendar | Nothing to do | | ||
| +-----------------------------------+-----------------------------------+ | ||
| |web_diagram | | | ||
| |web_diagram | Nothing to do | |
There was a problem hiding this comment.
As this module contains a migrations folder, it's convenient to include the openupgrade_analysis_work.txt file indicating that there's nothing to do. This way, looking at the folder structure without checking this documentation, you can see if the module has been analyzed.
pedrobaeza
left a comment
There was a problem hiding this comment.
Well, this is normally performed copying the analysis file, and adding on the corresponding sections "Nothing to do" for reviewers to check if it's that way, but it's very simple, so I approve it.
Travis error is unrelated and should be fixed when migrating crm.
851207f to
ac01fff
Compare
|
Fixed the work comments according to usual standards and rebased. |
|
There's something strange in the rebase. Please check. |
|
conflict solved |
|
I still see a lot of commits that don't belong here |
|
this branch still needs cleaning up |
8ef2dad to
7c20d3c
Compare
|
cannot find anything wrong except for the travis CRM, cleaned up from a fresh OCA 10.0 and cherry picked my small commit. |
7c20d3c to
8ef2dad
Compare
|
you didn't use a pristine 10.0 branch, but some other one that contains the extra commits @pedrobaeza and me are talking about |
8ef2dad to
ed23668
Compare
Description of the issue/feature this PR addresses:
Tagging web_calendar , web_diagram , web_kanban ,web_kanban_gauge as 'nothing to do'
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr