Skip to content

Nothing to do on these WEB_X modules - #799

Merged
hbrunn merged 1 commit into
OCA:10.0from
gfcapalbo:10.0-migration-X
May 11, 2017
Merged

Nothing to do on these WEB_X modules#799
hbrunn merged 1 commit into
OCA:10.0from
gfcapalbo:10.0-migration-X

Conversation

@gfcapalbo

Copy link
Copy Markdown

Description of the issue/feature this PR addresses:
Tagging web_calendar , web_diagram , web_kanban ,web_kanban_gauge as 'nothing to do'

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked folders and run the script for looking for noupdate changes. One a little comment that I think it's important.

|web_calendar | Nothing to do |
+-----------------------------------+-----------------------------------+
|web_diagram | |
|web_diagram | Nothing to do |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this module contains a migrations folder, it's convenient to include the openupgrade_analysis_work.txt file indicating that there's nothing to do. This way, looking at the folder structure without checking this documentation, you can see if the module has been analyzed.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is normally performed copying the analysis file, and adding on the corresponding sections "Nothing to do" for reviewers to check if it's that way, but it's very simple, so I approve it.

Travis error is unrelated and should be fixed when migrating crm.

@gfcapalbo
gfcapalbo force-pushed the 10.0-migration-X branch from 851207f to ac01fff Compare May 2, 2017 12:02
@gfcapalbo

Copy link
Copy Markdown
Author

Fixed the work comments according to usual standards and rebased.

@pedrobaeza

Copy link
Copy Markdown
Member

There's something strange in the rebase. Please check.

@gfcapalbo

Copy link
Copy Markdown
Author

conflict solved

@pedrobaeza

pedrobaeza commented May 5, 2017

Copy link
Copy Markdown
Member

I still see a lot of commits that don't belong here

@hbrunn hbrunn added this to the 10.0 milestone May 9, 2017
@hbrunn

hbrunn commented May 9, 2017

Copy link
Copy Markdown
Member

this branch still needs cleaning up

@gfcapalbo

Copy link
Copy Markdown
Author

cannot find anything wrong except for the travis CRM, cleaned up from a fresh OCA 10.0 and cherry picked my small commit.

@hbrunn

hbrunn commented May 10, 2017

Copy link
Copy Markdown
Member

you didn't use a pristine 10.0 branch, but some other one that contains the extra commits @pedrobaeza and me are talking about

@hbrunn
hbrunn merged commit 444de93 into OCA:10.0 May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants