Project - merge only after product has migration script merged - #826
Closed
gfcapalbo wants to merge 2 commits into
Closed
Project - merge only after product has migration script merged#826gfcapalbo wants to merge 2 commits into
gfcapalbo wants to merge 2 commits into
Conversation
|
product is merged |
Member
|
But why don't you update also documentation? |
Member
|
Please rename also as good practice removed fields for storing them in case of being need by any other module. |
gfcapalbo
changed the title
Author
|
added documentation |
Member
|
actually, there's something to do as @pedrobaeza pointed out: #848 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
nothing to do in project , but merge only After product has a migration script
Current behavior before PR:
project is not set as migrated
Desired behavior after PR is merged:
project set as
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr