[10.0][MIG] account_voucher - #845
Merged
Merged
Conversation
cubells
requested changes
May 29, 2017
Member
There was a problem hiding this comment.
Typo: there are 4 extra spaces... :)
MiquelRForgeFlow
force-pushed
the
10.0-account-voucher
branch
from
May 29, 2017 14:42
c20b770 to
1c5cfcc
Compare
cubells
approved these changes
May 29, 2017
| """) | ||
|
|
||
|
|
||
| @openupgrade.migrate(use_env=True) |
Member
There was a problem hiding this comment.
use_env=True is default so it's not necessary but this not block pr.
astirpe
approved these changes
May 29, 2017
NL66278
suggested changes
May 29, 2017
NL66278
left a comment
NL66278
left a comment
There was a problem hiding this comment.
This contains invalid SQL syntax.
Tip: to check SQL statements, just past them in the psql console (connected to a database migrated to 10.0).
Contributor
Author
|
@NL66278 comment attended to, thanks!! My mind thinks in MySQL instead of PostgreSQL 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the migration scripts to v10 for account_voucher module.