Skip to content

[9.0] openupgrade records install no localization - #866

Merged
pedrobaeza merged 2 commits into
OCA:9.0from
NL66278:9.0-openupgrade_records-install_no_localization
Jun 15, 2017
Merged

[9.0] openupgrade records install no localization#866
pedrobaeza merged 2 commits into
OCA:9.0from
NL66278:9.0-openupgrade_records-install_no_localization

Conversation

@NL66278

@NL66278 NL66278 commented May 30, 2017

Copy link
Copy Markdown

Description of the issue/feature this PR addresses: #860

Current behavior before PR: Install all modules misses option to leave out localizations

Desired behavior after PR is merged: You can specify not to install localizations

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaeza

Copy link
Copy Markdown
Member

I think the branch is incorrect with extra commits

@NL66278
NL66278 force-pushed the 9.0-openupgrade_records-install_no_localization branch from 69b638d to 9c38bbb Compare May 30, 2017 15:56
@NL66278

NL66278 commented May 30, 2017

Copy link
Copy Markdown
Author

@pedrobaeza I removed the commits that should not have been there

#
##############################################################################

# © 2012-2017 Therp BV <http://therp.nl>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with the new short headers, but please add copyright instead of replacing it.

@StefanRijnhart

Copy link
Copy Markdown
Member

The bug can be fixed with #872. Do you still need this?

@NL66278

NL66278 commented May 31, 2017

Copy link
Copy Markdown
Author

@StefanRijnhart I think the addition of the option to exclude localization modules is still quite usefull for manual analysis.

@pedrobaeza
pedrobaeza merged commit 47ac216 into OCA:9.0 Jun 15, 2017
@pedrobaeza

Copy link
Copy Markdown
Member

@NL66278, can you forward port this to 10.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants