Skip to content

[IMP] also install modules where there was nothing to do - #898

Merged
pedrobaeza merged 1 commit into
OCA:10.0from
hbrunn:10.0-install_nothing_to_do_modules
Jun 7, 2017
Merged

[IMP] also install modules where there was nothing to do#898
pedrobaeza merged 1 commit into
OCA:10.0from
hbrunn:10.0-install_nothing_to_do_modules

Conversation

@hbrunn

@hbrunn hbrunn commented Jun 7, 2017

Copy link
Copy Markdown
Member

we also should install modules that are considered nothing to do

@pedrobaeza

Copy link
Copy Markdown
Member

This should wait until we have a green build to see if everything is correct.

@hbrunn

hbrunn commented Jun 7, 2017

Copy link
Copy Markdown
Member Author

the intention is to get a green build with this. Modules like hr_contract won't be installed otherwise, and we need this to make base_action_rule work...
The problem now is that we have a bunch of modules depending on website migrated, while website itself errors out. I'll add a migration for that, let's see how this goes. But merging this won't make things worse, so I suggest to merge this anyways instead of hacking other stuff to make runbot green

@pedrobaeza

Copy link
Copy Markdown
Member

Puf, this is getting really complicated...

Are you going to include here website migration or in a separate PR?

@hbrunn

hbrunn commented Jun 7, 2017

Copy link
Copy Markdown
Member Author

separate (completely untested) PR: #899

@pedrobaeza

Copy link
Copy Markdown
Member

OK, merging this one, and reviewing the other.

@pedrobaeza
pedrobaeza merged commit f079061 into OCA:10.0 Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants