Skip to content

[10.0][MIG] Several website modules - #908

Merged
pedrobaeza merged 1 commit into
OCA:10.0from
ForgeFlow:10.0-several-website-modules
Jun 18, 2017
Merged

[10.0][MIG] Several website modules#908
pedrobaeza merged 1 commit into
OCA:10.0from
ForgeFlow:10.0-several-website-modules

Conversation

@MiquelRForgeFlow

@MiquelRForgeFlow MiquelRForgeFlow commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

This PR marks as #NothingToDo the following modules:

  • website_blog
  • website_crm
  • website_crm_partner_assign
  • website_event
  • website_event_sale (without analysis file)
  • website_google_map (without analysis file)
  • website_hr (without analysis file)
  • website_mail
  • website_membership (without analysis file)
  • website_partner
  • website_project

@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 10.0-several-website-modules branch 2 times, most recently from 80e0712 to 5009bf9 Compare June 12, 2017 10:25
@pedrobaeza

Copy link
Copy Markdown
Member

Have you checked noupdate records with the script compare_noupdate_records.py?

@JordiBForgeFlow

Copy link
Copy Markdown
Member

@pedrobaeza @hbrunn We have never used the script compare_noupdate_records.py before. Any tips on how to run it? Perhaps it would be good to run it for all modules, and create an analysis file with the results, so that we can consistently analyze this output?

@pedrobaeza

Copy link
Copy Markdown
Member

The problem is that it has to be done manually. The use is very simple:

python compare_noupdate_records.py <previous_version_module_path> <current_version_module_path>

The script can be updated for taking a full addons path and drop the noupdate_records.xml files inside migrations folder indeed, but will require much work.

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

Hey, are you refering to compare_noupdate_xml_records.py
instead of compare_noupdate_records.py, right?

@pedrobaeza

Copy link
Copy Markdown
Member

Yeah, I was talking out of memory. The name is pretty similar, hehe 😄

@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 10.0-several-website-modules branch from 5009bf9 to 5d20953 Compare June 13, 2017 11:57
@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 10.0-several-website-modules branch from 5d20953 to b90f1fa Compare June 13, 2017 11:58
@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

@pedrobaeza I just checked all the noupdate records. It was useful to realize that website_project was a new module 😉

Ready to be merged.

@pedrobaeza
pedrobaeza merged commit 4436f7a into OCA:10.0 Jun 18, 2017
@MiquelRForgeFlow
MiquelRForgeFlow deleted the 10.0-several-website-modules branch July 21, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants