Skip to content

[9.0][Upd] module coverage list - #913

Merged
pedrobaeza merged 1 commit into
OCA:9.0from
ForgeFlow:9.0-upd-module-coverage-list
Jun 19, 2017
Merged

[9.0][Upd] module coverage list#913
pedrobaeza merged 1 commit into
OCA:9.0from
ForgeFlow:9.0-upd-module-coverage-list

Conversation

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

I found very useful in v10 the image tag to know which modules are missing. So I thought to apply the same in v9.

The changes in this PR are not an exhaustive list of missing modules but it's a first approach.

@pedrobaeza

Copy link
Copy Markdown
Member

Please complete the list then, or we will think that it's complete.

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

The list is now exhaustively completed 💪😎

@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 9.0-upd-module-coverage-list branch 2 times, most recently from 08854ca to 35ab610 Compare June 14, 2017 13:29

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be account_check_printing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writing vs printing? 😏

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see that this a foot note, but at first sight I saw renamed and the same name and thought that there was an error.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are changing the entire file, better to give some more room to the columns, specially the second column that can contain references to renamings

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who encounters a problem with the width of the second column is who should change the width, not me 😒

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but this means again another full diff. That's why I asking you this favor for not having such big diffs each time.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I encountered the problem 😂

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing in the second column is done 👍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an equivalent module and OpenUpgrade renames it to it in https://github.com/OCA/account-analytic/tree/9.0/account_analytic_distribution

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 9.0-upd-module-coverage-list branch from 5dfbf72 to 7091b4c Compare June 19, 2017 09:10
@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

It's ready @pedrobaeza

@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 9.0-upd-module-coverage-list branch from 7091b4c to 2f4ec21 Compare June 19, 2017 09:29

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Now the documentation shines much more brighter 😉

@pedrobaeza

Copy link
Copy Markdown
Member

Travis error is as always due to incorrect TRAVIS_COMMIT environment variable, so it's safe to merge.

@pedrobaeza
pedrobaeza merged commit 4c466f1 into OCA:9.0 Jun 19, 2017
@MiquelRForgeFlow
MiquelRForgeFlow deleted the 9.0-upd-module-coverage-list branch July 21, 2017 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants