[10.0][MIG] sale_crm - #941
Merged
Merged
Conversation
pedrobaeza
requested changes
Jun 29, 2017
Member
There was a problem hiding this comment.
As you have a field invoice_ids in sale.order, you should fill these fields from sale.order to the associated invoices.
pedrobaeza
force-pushed
the
10.0-sale_crm
branch
from
June 29, 2017 23:57
54e5b6f to
fc6741e
Compare
MiquelRForgeFlow
force-pushed
the
10.0-sale_crm
branch
2 times, most recently
from
June 30, 2017 10:50
9826e02 to
7453acf
Compare
Member
|
Errores de flake8: |
MiquelRForgeFlow
force-pushed
the
10.0-sale_crm
branch
from
June 30, 2017 16:07
0a585ee to
d9ffebd
Compare
pedrobaeza
requested changes
Jun 30, 2017
Member
There was a problem hiding this comment.
No need to make subquery:
UPDATE account_invoice ai
SET campaign_id = so.campaign_id,
medium_id = so.medium_id,
source_id = so.source_id
FROM account_invoice_line ail,
sale_order_line sol,
sale_order so,
sale_order_line_invoice_rel rel
WHERE ai.id = ail.invoice_id
AND ail.id = rel.invoice_line_id
AND rel.order_line_id = sol.id
AND sol.order_id = so.id
MiquelRForgeFlow
force-pushed
the
10.0-sale_crm
branch
from
July 3, 2017 08:20
c027be3 to
42a4c1e
Compare
pedrobaeza
approved these changes
Jul 4, 2017
pedrobaeza
requested changes
Jul 4, 2017
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
I'm thinking in one last thing: better to call openupgrade.logged_query instead a plain cr.execute to register the operation in the log.
MiquelRForgeFlow
force-pushed
the
10.0-sale_crm
branch
from
July 4, 2017 08:03
42a4c1e to
c01705f
Compare
pedrobaeza
approved these changes
Jul 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added migration scripts and checked noupdate records.