Skip to content

[10.0][MIG] all payment_* modules - #971

Merged
pedrobaeza merged 1 commit into
OCA:10.0from
ForgeFlow:10.0-mig-payment_paypal-and-tranfer
Aug 4, 2017
Merged

[10.0][MIG] all payment_* modules#971
pedrobaeza merged 1 commit into
OCA:10.0from
ForgeFlow:10.0-mig-payment_paypal-and-tranfer

Conversation

@MiquelRForgeFlow

@MiquelRForgeFlow MiquelRForgeFlow commented Jul 26, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updated documentation
  • Included analysis work file
  • Included migration scripts
  • Checked noupdate=1 records

pedrobaeza
pedrobaeza requested changes Jul 26, 2017
View reviewed changes

@pedrobaeza pedrobaeza left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to rename both payment.acquirer XML-IDs for avoiding to have duplicate acquirer records on new version and incorrect references.

@pedrobaeza pedrobaeza mentioned this pull request Jul 26, 2017
Closed
@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 10.0-mig-payment_paypal-and-tranfer branch 2 times, most recently from 83b3c15 to b1c7e42 Compare July 27, 2017 08:31
@MiquelRForgeFlow

MiquelRForgeFlow commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

It's seems Travis didn't like the renames.

@pedrobaeza

pedrobaeza commented Jul 27, 2017

Copy link
Copy Markdown
Member

I see the problem: now the acquirers are declared on main payment module (https://github.com/OCA/OpenUpgrade/blob/10.0/addons/payment/data/payment_acquirer_data.xml), so you have to include these renamings (all of them) in that module migration.

@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 10.0-mig-payment_paypal-and-tranfer branch from b1c7e42 to ffc9c94 Compare July 27, 2017 11:42
@MiquelRForgeFlow MiquelRForgeFlow changed the title [10.0][MIG] payment_paypal & payment_transfer [10.0][MIG] all payment_* modules Jul 27, 2017
@pedrobaeza
pedrobaeza merged commit 78a2a74 into OCA:10.0 Aug 4, 2017
@MiquelRForgeFlow
MiquelRForgeFlow deleted the 10.0-mig-payment_paypal-and-tranfer branch August 6, 2017 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MiquelRForgeFlow @pedrobaeza