Skip to content

[10.0][MIG] portal/portal_sale/portal_stock - #972

Merged
pedrobaeza merged 2 commits into
OCA:10.0from
ForgeFlow:10.0-mig-portal
Jul 27, 2017
Merged

[10.0][MIG] portal/portal_sale/portal_stock#972
pedrobaeza merged 2 commits into
OCA:10.0from
ForgeFlow:10.0-mig-portal

Conversation

@MiquelRForgeFlow

@MiquelRForgeFlow MiquelRForgeFlow commented Jul 26, 2017

Copy link
Copy Markdown
Contributor
  • Updated documentation
  • Included analysis work file
  • Included migration scripts
  • Checked noupdate=1 records

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v9 version of portal_sale overwrites the method action_quotation_send of the model sale.order, changing the default template to be used for sending the mail to the one provided by this module. As now there's no such change (as the template itself disappears), we expect that the default template will be the same (and we can even customize this template to our needs, not the sale one).

Following this rationale, you have to provide a migration script here, that removes xml-id reference to sale.email_template_edi_sale, and rename XML-ID portal_sale.email_template_edi_sale to sale.email_template_edi_sale.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same logic applies also for the invoice template.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't get it 😳

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do:

env['ir.model.data'].search([
    ('module', '=', 'sale'),
    ('name', '=', 'email_template_edi_sale'),
]).unlink()
openupgrade.rename_xml_ids([
    ('sale_portal.email_template_edi_sale',
     'sale.email_template_edi_sale'),
])

and the same with invoice one.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pedrobaeza pedrobaeza mentioned this pull request Jul 27, 2017
@pedrobaeza pedrobaeza changed the title [10.0][MIG] portal [10.0][MIG] portal/portal_sale/portal_stock Jul 27, 2017
@gfcapalbo

Copy link
Copy Markdown

@pedrobaeza thanks , missed the template.

@pedrobaeza
pedrobaeza merged commit 6f62c04 into OCA:10.0 Jul 27, 2017
@MiquelRForgeFlow
MiquelRForgeFlow deleted the 10.0-mig-portal branch July 27, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants