Skip to content

[10.0][MIG] im_livechat - #973

Merged
pedrobaeza merged 1 commit into
OCA:10.0from
ForgeFlow:10.0-mig-im_livechat
Aug 4, 2017
Merged

[10.0][MIG] im_livechat#973
pedrobaeza merged 1 commit into
OCA:10.0from
ForgeFlow:10.0-mig-im_livechat

Conversation

@MiquelRForgeFlow

@MiquelRForgeFlow MiquelRForgeFlow commented Jul 26, 2017

Copy link
Copy Markdown
Contributor
  • Updated documentation
  • Included analysis work file
  • Included migration scripts
  • Checked noupdate=1 records

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to manually remove this cron in a migration script as this is flagged noupdate=1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to manually remove this todo in a migration script as this is flagged noupdate=1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to manually remove this action in a migration script as this is flagged noupdate=1

@MiquelRForgeFlow MiquelRForgeFlow Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the compare_noupdate_xml_records script and the result was nothing. The ir.actions.* always are ignored. If you insist, please, show me an existing example of removing ir.actions.*

@pedrobaeza pedrobaeza Jul 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already talked about this. This is something that the script is not going to detect. It's simply: noupdate=1 records are not automatically removed if they disappear, and thus, all of these records will remain. Imagine a cron that is logging error each time it's executed because the method that is calling is missing. That's one of the cases of not removing these noupdate=1 records.

@pedrobaeza pedrobaeza Jul 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to remove the records, not the XML-IDs:

xml_ids = [
    'im_livechat.ir_action_client_open_livechat_menu',
    'im_livechat.ir_cron_remove_empty_session',
]
for xml_id in xml_ids:
    self.env.ref(xml_id).unlink()

I have seen that the the record referenced from base module is not needed.

@pedrobaeza

Copy link
Copy Markdown
Member

@mreficent next time you make an amend/squash and git push -f, please throw a message in the PR as we are not notified about this push.

@pedrobaeza
pedrobaeza merged commit e2129a9 into OCA:10.0 Aug 4, 2017
@MiquelRForgeFlow
MiquelRForgeFlow deleted the 10.0-mig-im_livechat branch August 6, 2017 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants