10.0 website mass mailing - #979
Closed
gfcapalbo wants to merge 4 commits into
Closed
Conversation
pedrobaeza
reviewed
Jul 27, 2017
| cr.execute(sql) | ||
| sql = "update mail_mass_mailing_list set popup_redirect_url = %s" % ( | ||
| openupgrade.get_legacy_name('popup_redirect_url') | ||
| ) |
Member
|
Any news on this? |
Member
|
Hi, are you going to finish this? |
improve comment
Author
|
Added the commit , checked the change log. Still testing but I think it is complete. |
Member
|
@gfcapalbo thanks for the update. Looking now at the migration script, I think there's actually nothing to do, as the columns are not dropped during OpenUpgrade mass_mailing update process, so they will be there when updating website_mass_mailing. |
Member
|
Closing in favour of #1526 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr