[15.0][MIG] connector_importer_product by simahawk · Pull Request #94 · OCA/connector-interfaces

simahawk · 2022-07-15T09:57:32Z

Module moved as-is to 15.0 here #99

Depends on:

[15.0] connector_importer: misc fix/imp #98

TODO:

finish testing

Overall:

removed a lot of custom code thanks to the dynamic mapper
update configuration of default import types
improved and fixed product and supplier importers
added tests

See atomic commits for details.

simahawk · 2022-07-15T09:57:57Z

/ocabot migration connector_importer_product

simahawk · 2023-03-02T10:57:28Z

I'm experimenting w/ pyopenssl upgrade. BTW there's s pending PR on master here odoo/odoo#95782

Error w/o upgrade:

Traceback (most recent call last):
  File "/opt/odoo/odoo/modules/registry.py", line 87, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/opt/odoo/odoo/modules/loading.py", line 415, in load_modules
    loaded_modules, processed_modules = load_module_graph(
  File "/opt/odoo/odoo/modules/loading.py", line 179, in load_module_graph
    load_openerp_module(package.name)
  File "/opt/odoo/odoo/modules/module.py", line 396, in load_openerp_module
    __import__('odoo.addons.' + module_name)
  File "/opt/odoo/odoo/addons/base/__init__.py", line 5, in <module>
    from . import models
  File "/opt/odoo/odoo/addons/base/models/__init__.py", line 23, in <module>
    from . import ir_mail_server
  File "/opt/odoo/odoo/addons/base/models/ir_mail_server.py", line 19, in <module>
    from OpenSSL import crypto as SSLCrypto
  File "/opt/odoo-venv/lib/python3.8/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import crypto, SSL
  File "/opt/odoo-venv/lib/python3.8/site-packages/OpenSSL/crypto.py", line 1553, in <module>
    class X509StoreFlags(object):
  File "/opt/odoo-venv/lib/python3.8/site-packages/OpenSSL/crypto.py", line 1573, in X509StoreFlags
    CB_ISSUER_CHECK = _lib.X509_V_FLAG_CB_ISSUER_CHECK
AttributeError: module 'lib' has no attribute 'X509_V_FLAG_CB_ISSUER_CHECK'

Error w/ 21.0.0, now testing 20.0.

2023-03-02 10:50:48,297 236 ERROR odoo odoo.modules.registry: Failed to load registry 
2023-03-02 10:50:48,297 236 CRITICAL odoo odoo.service.server: Failed to initialize database `odoo`. 
Traceback (most recent call last):
  File "/opt/odoo/odoo/modules/registry.py", line 87, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/opt/odoo/odoo/modules/loading.py", line 415, in load_modules
    loaded_modules, processed_modules = load_module_graph(
  File "/opt/odoo/odoo/modules/loading.py", line 179, in load_module_graph
    load_openerp_module(package.name)
  File "/opt/odoo/odoo/modules/module.py", line 396, in load_openerp_module
    __import__('odoo.addons.' + module_name)
  File "/opt/odoo/odoo/addons/base/__init__.py", line 5, in <module>
    from . import models
  File "/opt/odoo/odoo/addons/base/models/__init__.py", line 23, in <module>
    from . import ir_mail_server
  File "/opt/odoo/odoo/addons/base/models/ir_mail_server.py", line 19, in <module>
    from OpenSSL import crypto as SSLCrypto
  File "/opt/odoo-venv/lib/python3.8/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import crypto, SSL
  File "/opt/odoo-venv/lib/python3.8/site-packages/OpenSSL/crypto.py", line 3279, in <module>
    _lib.OpenSSL_add_all_algorithms()
AttributeError: module 'lib' has no attribute 'OpenSSL_add_all_algorithms'

These versions work:

pyopenssl==20.0.0
cryptography==35.0.0

simahawk · 2023-03-06T12:53:38Z

Fixed here OCA/storage#248

The mapper now uses the dynanic mapper to automatically find and convert values from source to destination. We can trash many direct mappings! Additionally, the supplier is now imported automatically.

`prod.product_template_attribute_value_ids` must be set using _only_ valid values. To find them, we must use `_without_no_variant_attribute()` as Odoo does in relevant places. `combination_indices` depends on `product_template_attribute_value_ids`, hence if its value is wrong the index will be wrong and you won't find the right variant. Additionally, when using the product configurator, since the combination is wrong the product won't be purchase-able or sale-able w/ the configurator.

Make import type non demo only to provide a default setup.

Allows to import product and suppliers at the same time.

simahawk · 2023-03-06T13:17:55Z

/ocabot merge minor

OCA-git-bot · 2023-03-06T13:18:00Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-94-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot · 2023-03-06T13:22:31Z

Congratulations, your PR was merged at 2f34556. Thanks a lot for contributing to OCA. ❤️

simahawk added the work in progress label Jul 15, 2022

OCA-git-bot added this to the 15.0 milestone Jul 15, 2022

OCA-git-bot mentioned this pull request Jul 15, 2022

Migration to version 15.0 #84

Open

4 tasks

simahawk force-pushed the 15-conn-importer-product branch from ada7ea4 to 56bf467 Compare November 7, 2022 10:37

simahawk mentioned this pull request Nov 7, 2022

[15.0] connector_importer_product: port not installable #99

Merged

simahawk force-pushed the 15-conn-importer-product branch 2 times, most recently from 92a5b6d to 8eff96e Compare November 8, 2022 08:45

simahawk force-pushed the 15-conn-importer-product branch from 8eff96e to 55d6b5e Compare November 24, 2022 09:19

simahawk marked this pull request as ready for review March 2, 2023 10:35

simahawk removed the work in progress label Mar 2, 2023

simahawk force-pushed the 15-conn-importer-product branch 2 times, most recently from be05f63 to d665eec Compare March 2, 2023 10:54

This was referenced Mar 2, 2023

[15.0][UPD] repo template OCA/storage#247

Closed

As a user i can't create a report #92

Closed

[16.0] connector_importer_product: port as not installable #107

Merged

simahawk force-pushed the 15-conn-importer-product branch from d665eec to 33e9f57 Compare March 6, 2023 12:11

simahawk force-pushed the 15-conn-importer-product branch from 33e9f57 to 47db841 Compare March 6, 2023 12:57

simahawk added 10 commits March 6, 2023 14:13

connector_importer_product: migrate to v15

cc86785

connector_importer_product: mapper fixes

7587b9a

c_importer_product: split product importer files

9bc79f4

c_importer_product: make importer and mapper smarter

dc5d9cb

The mapper now uses the dynanic mapper to automatically find and convert values from source to destination. We can trash many direct mappings! Additionally, the supplier is now imported automatically.

c_importer_product: improve attr value FIXME

cbf2d91

c_importer_product: improve product import

4a41618

c_importer_product: improve supplierinfo import

95364b3

c_importer_product: add default import.type

04c5df6

Make import type non demo only to provide a default setup.

c_importer_product: add only-in-one type

1e0eb5c

Allows to import product and suppliers at the same time.

simahawk added 14 commits March 6, 2023 14:13

c_importer_product: add tests common class

0354aa6

c_importer_product: add tests for prod category

4070950

c_importer_product: drop category specific importer

10cc038

c_importer_product: silent tests logger

7149bff

c_importer_product: drop custom prod attribute importer

c172ea0

c_importer_product: drop custom prod attribute value importer

5d303f9

c_importer_product: drop custom prod pkg importer

5ce275a

connector_importer_product: skip barcode when empty

0ed1ac0

connector_importer_product: improve attr value lookup

33a4dab

connector_importer_product: drop dead code

ea2d3e3

connector_importer_product: improve product import test cov

b857fc2

connector_importer_product: adapt default import.type conf

93f517f

connector_importer: add TODO in ROADMAP

efabb93

connector_importer_product: fix author name

bc379cd

simahawk force-pushed the 15-conn-importer-product branch from 47db841 to bc379cd Compare March 6, 2023 13:13

OCA-git-bot added the bot is merging ⏳ label Mar 6, 2023

OCA-git-bot merged commit b303404 into OCA:15.0 Mar 6, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[15.0][MIG] connector_importer_product#94

[15.0][MIG] connector_importer_product#94
OCA-git-bot merged 24 commits intoOCA:15.0from
camptocamp:15-conn-importer-product

simahawk commented Jul 15, 2022 •

edited

Loading

Uh oh!

simahawk commented Jul 15, 2022

Uh oh!

simahawk commented Mar 2, 2023

Uh oh!

simahawk commented Mar 6, 2023

Uh oh!

simahawk commented Mar 6, 2023

Uh oh!

OCA-git-bot commented Mar 6, 2023

Uh oh!

OCA-git-bot commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

simahawk commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simahawk commented Jul 15, 2022

Uh oh!

simahawk commented Mar 2, 2023

Uh oh!

simahawk commented Mar 6, 2023

Uh oh!

simahawk commented Mar 6, 2023

Uh oh!

OCA-git-bot commented Mar 6, 2023

Uh oh!

OCA-git-bot commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

simahawk commented Jul 15, 2022 •

edited

Loading