[16.0][MIG] dms by vancouver29 · Pull Request #262 · OCA/dms

vancouver29 · 2023-09-18T16:12:28Z

[16.0][MIG] dms

…ails, preview

versions of muk_dms than 12.0.2.0.0. Tested from 1.2.4 version.

In v13, this test is programmed in such a way that the demo user is supposed to be able to copy that subdirectory: https://github.com/OCA/dms/blob/c3f802db43362127e70d8c7b4987fb71d4c1f01c/dms/tests/test_directory.py#L40 However, in OCA#7 that test was modified indicating that demo user didn't have permissions to do that: https://github.com/OCA/dms/blob/e3b6d8d24534f2a68bfb88e310cc70cefe46bb64/dms/tests/test_directory.py#L39 Rolling back that change to ensure premissions remain the same in both versions of the module. Also changing the directory to test to ensure it contains no SVG files, whose detection seems to differ among environments, and which have some specific permission restrictions that can make the modified test fail or pass. @Tecnativa TT25645

…tions

OCA-git-bot · 2023-10-24T15:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza

Are video and audio correctly previewed without the extra dependencies?

pedrobaeza · 2023-10-25T16:28:33Z

Please add #264

vancouver29 · 2023-10-29T11:07:06Z

Please add #264

Did you test it in dms v16?

I tried to reproduce the problem, which is described here #263 with the user Mark Demo. But No Error has occurred. So I think we don't need this.

len-foss · 2023-10-30T12:18:01Z

With regards to the PR mentioned, the fix is in dms_field, you cannot apply half of it, and the half you can apply doesn't make sense on its own. Given that the compute field on model could be added in an override in dms_field, it's technically not really right to put that code in dms.

pedrobaeza · 2023-10-30T12:20:28Z

Well, I disagree here, as any other chance to have a non sudo access will provoke the same problem, so it's better to fix it in the root, as it also doesn't cause any cons.

len-foss · 2023-10-30T12:40:49Z

Well but the problem is that there is no path for reproduction, as @vancouver29 noted, and no test that can be written in dms.
As it stands it's the code from dms_field that emits the domain triggering the error.
So if you look at the code, it isn't used anywhere, and the commit message says "Improve search by model". Without going back to the Github PR, there is nothing that indicates why this code should exist.

There should be a comment explaining why it is useful, or at the very least this information should be in the commit message. Something like "while this field is not used, depending modules might need to search on model; however the document manager might not have read access to ir.model".

pedrobaeza · 2023-10-30T12:49:11Z

OK, agreed of explaining everything better. The fix and its explanation can be added later in a subsequent PR.

agent-z28

For me it looks very good now, i tested it and seems to be a nice module. Thanks for your effort :)

marylla · 2023-11-03T13:38:41Z

@pedrobaeza Can we merge this DMS PR?

pedrobaeza · 2023-11-03T15:38:57Z

/ocabot merge nobump
/ocabot migration dms

OCA-git-bot · 2023-11-03T15:39:18Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-262-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-11-03T15:50:28Z

Congratulations, your PR was merged at f14e58c. Thanks a lot for contributing to OCA. ❤️

vancouver29 · 2023-11-04T08:21:23Z

On the file CREDITS.rst, put that the migration to 16.0 has been funded by agent-z18, and on contributors, put your names.

@pedrobaeza thank you very much for merging this work. But I don't see the changes in README.rst anymore (we are contributors and @agent-z28 is the sponsor for this migration from v15 to v16). Is something here missing? @marylla FYI

pedrobaeza · 2023-11-04T09:09:56Z

You didn't modify readme/CREDITS.rst nor readme/CONTRIBUTORS.rst, but README.rst, so that's why your changes are lost. Read again my comment, in which I mention the file. Do another PR introducing that changes.

len-foss · 2023-11-04T09:20:32Z

@vancouver29 You can check that your changes would be properly applied by running the maintainer tools manually. Just install it with pipx and run oca-gen-addon-readme --repo-name=dms --branch=16.0 --addon-dir=dms, this way you won't have any surprise once your PR is merged.

https://github.com/OCA/maintainer-tools#readme-generator

pedrobaeza · 2023-11-04T09:53:11Z

Now only having pre-commit, the readme regeneration is done.

vancouver29 · 2023-11-06T08:17:22Z

You didn't modify readme/CREDITS.rst nor readme/CONTRIBUTORS.rst, but README.rst, so that's why your changes are lost. Read again my comment, in which I mention the file. Do another PR introducing that changes.

@pedrobaeza Sorry, my fault! Thanks for the hint again. I just created a new PR here #268

@vancouver29 You can check that your changes would be properly applied by running the maintainer tools manually. Just install it with pipx and run oca-gen-addon-readme --repo-name=dms --branch=16.0 --addon-dir=dms, this way you won't have any surprise once your PR is merged.

https://github.com/OCA/maintainer-tools#readme-generator

@len-foss, thank you very much for the hint. I will notice it next time :)

Mathias Markl and others added 30 commits September 18, 2023 17:01

Version 1.0.0

6e1c3a7

9.0 > 10.0

71032f2

added markdown preview using showdown js library

a5808d1

update

bac8561

Add Ukrainian translation to mik_dms and muk_dms_access

845762d

Documents 2.0

a23ca31

publish muk_dms - 11.0

71f151b

v12

1c4272c

[IMP] : black, isort, prettier

de817c0

[MIG] dms: from muk_dms to dms

1450027

[MIG] Dms tag

2f33a8b

[MIG] dms: File

0c0641f

[MIG][13.0] dms: Finish migration

b479c2f

[IMP] Minor mig fixes

d6ac81d

[MIG] dms: fix tests

1e832e2

[IMP] Add security groups

b3991dd

[ADD] dms: add funcionality of muk_dms_file

02bba1e

[MIG] dms: File functionality

bb07837

[IMP] dms: Allow to drag and drop

9d7fddd

[FIX] Various fixes

7c10184

[IMP] dms: Add mail

c23657c

[FIX] dms: remove unused code and fixing: webpanel, migration, thumbn…

0b4088c

…ails, preview

[IMP] dms: add migration script for muk_dms

4176f1e

[13.0][MIG] dms: make migrations scripts compatible with older

add1d27

versions of muk_dms than 12.0.2.0.0. Tested from 1.2.4 version.

[FIX] dms: Download file with its proper name

b16c71e

[FIX] dms: missing banner images & Load fields on the usual way

1f01719

[FIX] dms: Fix preview widget

30b9df6

[IMP] dms: Portal

95e8d96

[FIX] dms: /my/dms change to user and separate some urls in some func…

1d6ed9c

…tions

pedrobaeza reviewed Oct 24, 2023

View reviewed changes

Comment thread dms/models/dms_file.py Outdated

Comment thread dms/views/dms_file.xml

len-foss reviewed Oct 24, 2023

View reviewed changes

Comment thread dms/models/dms_file.py Outdated

vancouver29 force-pushed the 16.0-mig-dms-kbui branch 2 times, most recently from 70ee0d4 to 162ff0c Compare October 29, 2023 10:49

len-foss reviewed Oct 29, 2023

View reviewed changes

Comment thread dms/models/dms_file.py Outdated

len-foss reviewed Oct 29, 2023

View reviewed changes

Comment thread dms/models/dms_file.py Outdated

[MIG] dms: Migration from 15.0 to 16.0

05f7c67

vancouver29 force-pushed the 16.0-mig-dms-kbui branch from 162ff0c to 05f7c67 Compare October 30, 2023 09:17

agent-z28 approved these changes Nov 3, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Nov 3, 2023

OCA-git-bot merged commit 4101217 into OCA:16.0 Nov 3, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 3, 2023

victoralmau mentioned this pull request Apr 9, 2026

[18.0][IMP] dms: Clean up attachments after creation of file #470

Closed

Uh oh!

Uh oh!

Conversation

vancouver29 commented Sep 18, 2023

Uh oh!

OCA-git-bot commented Oct 24, 2023

Uh oh!

pedrobaeza left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pedrobaeza commented Oct 25, 2023

Uh oh!

vancouver29 commented Oct 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

len-foss commented Oct 30, 2023

Uh oh!

pedrobaeza commented Oct 30, 2023

Uh oh!

len-foss commented Oct 30, 2023

Uh oh!

pedrobaeza commented Oct 30, 2023

Uh oh!

agent-z28 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marylla commented Nov 3, 2023

Uh oh!

pedrobaeza commented Nov 3, 2023

Uh oh!

OCA-git-bot commented Nov 3, 2023

Uh oh!

OCA-git-bot commented Nov 3, 2023

Uh oh!

vancouver29 commented Nov 4, 2023

Uh oh!

pedrobaeza commented Nov 4, 2023

Uh oh!

len-foss commented Nov 4, 2023

Uh oh!

pedrobaeza commented Nov 4, 2023

Uh oh!

vancouver29 commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

pedrobaeza left a comment •

edited

Loading

vancouver29 commented Oct 29, 2023 •

edited

Loading

agent-z28 left a comment •

edited

Loading