[MIG][9.0][website_sale_vat_required] Migrate#174
Closed
Conversation
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes: - Moved from `OCA/website` to `OCA/e-commerce`. - Reduced license headers to new style ones, keeping copyright. - Updated README template. - Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon). - Benefit from upstream updates, that now handles incorrect VAT errors.
34 tasks
yajo
added a commit
to OCA/website
that referenced
this pull request
May 4, 2017
This addon is being moved to e-commerce. See OCA/e-commerce#174.
yajo
added a commit
to OCA/website
that referenced
this pull request
May 4, 2017
This addon is being moved to e-commerce. See OCA/e-commerce#174.
Member
|
There is some problem with runbot not beign able to load the repo: |
felixvillafranca
suggested changes
May 31, 2017
felixvillafranca
left a comment
felixvillafranca
left a comment
There was a problem hiding this comment.
Please could you fix _get_optional_billing_fields of main controller.
| return result | ||
|
|
||
| def _get_optional_billing_fields(self): | ||
| result = super(WebsiteSale, self)._get_mandatory_billing_fields() |
There was a problem hiding this comment.
This would be:
result = super(WebsiteSale, self)._get_optional_billing_fields()
felixvillafranca
approved these changes
Jun 1, 2017
felixvillafranca
left a comment
felixvillafranca
left a comment
There was a problem hiding this comment.
Good, thanks for fixing.
Funtional Ok.
pedrobaeza
approved these changes
Jun 8, 2017
Member
|
Something strange has happened merging the PR, but the commits are there on 9.0, so I close. |
acsone-git-bot
pushed a commit
to acsone/e-commerce
that referenced
this pull request
Jun 8, 2017
…ed-mig [MIG][9.0][website_sale_vat_required] Migrate
lasley
pushed a commit
to LasLabs/website
that referenced
this pull request
Jul 19, 2017
This addon is being moved to e-commerce. See OCA/e-commerce#174.
lasley
pushed a commit
to LasLabs/website
that referenced
this pull request
Aug 11, 2017
This addon is being moved to e-commerce. See OCA/e-commerce#174.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addon got migrated from 8.0. Relevant notes:
OCA/websitetoOCA/e-commerce.@Tecnativa