[MIG] website_sale_hide_empty_category: Migration to 11.0 #256
Merged
pedrobaeza merged 3 commits intoOCA:11.0from Nov 22, 2018
remytms:11.0-mig-website_sale_hide_empty_category
Merged
[MIG] website_sale_hide_empty_category: Migration to 11.0 #256pedrobaeza merged 3 commits intoOCA:11.0from remytms:11.0-mig-website_sale_hide_empty_category
pedrobaeza merged 3 commits intoOCA:11.0from
remytms:11.0-mig-website_sale_hide_empty_category
Conversation
* [ADD] website_sale_category_empty: Create module * Add module to hide categories that have no products associated with them * [FIX] website_sale_hide_empty_category: PR Fix * Add trailing comma to manifest * Rename Module
Contributor
Author
|
Did I use the right process ? I have cherry-pick all the commit from this PR : OCA/website#530 |
Member
|
Yes! Thank you very much |
38 tasks
pedrobaeza
approved these changes
Nov 1, 2018
simahawk
approved these changes
Nov 5, 2018
Contributor
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
2 minor issues, approving to not get back ;)
Contributor
Author
|
@simahawk , @pedrobaeza , Thanks for yours reviews. Things are good now. :) |
simahawk
approved these changes
Nov 7, 2018
Contributor
Author
|
@simahawk , Is it possible to merge this PR or do I need other review before that ? I think I can't do it because I don't see the merge button. |
Contributor
|
@pedrobaeza ping :) |
Contributor
Author
|
@pedrobaeza , @simahawk , is it time to merge ? :D |
Contributor
Author
|
@pedrobaeza Thanks a lot ! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrade the
website_sale_hide_empty_categoryfrom 10.0 to 11.0 and move it fromwebsitetoe-commerce.