Skip to content

[MIG] website_sale_category_megamenu: Migration to 11.0#259

Closed
remytms wants to merge 6 commits intoOCA:11.0from
remytms:11.0-megamenu-improve
Closed

[MIG] website_sale_category_megamenu: Migration to 11.0#259
remytms wants to merge 6 commits intoOCA:11.0from
remytms:11.0-megamenu-improve

Conversation

@remytms
Copy link
Contributor

@remytms remytms commented Nov 22, 2018

Hi,

I've ported this module to 11.0. And then I refactored it to use the Customize Menu in the Odoo Website.

Before it looked like this:
before

After:
after

And the Customize menu:
after_customize

Waiting for your comments. :)

Copy link

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong tab sorry, trying to dismiss this review

@simahawk
Copy link
Contributor

simahawk commented Dec 5, 2018

@robinkeunen English please :)

Split functionalities in different templates that can be enabled or
disabled in the Customize menu in the website.

Create a new division in the html where mega menu and other
functionalities are placed.

Facilitate the extension of this module by having specific templates to
insert functionalities in the parent view. So that new component can be
moved easier by another module.

Replace the usage of `@class` by `hasclass`.

This module is like this more generic.
@sergio-teruel
Copy link
Contributor

Can we close this PR?

@remytms
Copy link
Contributor Author

remytms commented May 27, 2019

@sergio-teruel This PR is not merged yet into OCA, I prefer to leave it open. I'm waiting for reviews. I'm ready to change anything that seems wrong to the community.
Thanks

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you preserving commit history? Thanks @remytms


* Daniel Gómez-Zurita <danielgz@antiun.com>
* Antonio Espinosa <antonioea@antiun.com>
* Rafael Blasco <rafaelbn@antiun.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to rafael.blasco@tecnativa.com

"version": "11.0.1.0.1",
"category": "Themes/Miscellaneous",
"website": "https://github.com/OCA/e-commerce/",
"author": "Antiun Ingeniería S.L., Odoo Community Association (OCA)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please add Tecnativa as we change from Antiun to Tecnativa

@rafaelbn
Copy link
Member

rafaelbn commented Sep 2, 2019

Maybe @mFlayyan is interested in review this PR and you @remytms could review his PR #127

Remember, per each PR you make you should review 3 PR from others! 😄

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

------------

* Daniel Gómez-Zurita <danielgz@antiun.com>
* Antonio Espinosa <antonioea@antiun.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This email also doesn't exist any more, just leave the name

@rafaelbn
Copy link
Member

rafaelbn commented Sep 5, 2019

Hi @remytms 😄

@sergio-teruel This PR is not merged yet into OCA, I prefer to leave it open. I'm waiting for reviews. I'm ready to change anything that seems wrong to the community.
Thanks

I reviewed ! thanks you!

@remytms
Copy link
Contributor Author

remytms commented Nov 25, 2020

There is missing commit in my PR. I will not redo all the work. I have started from the 9.0 branch instead of the 8.0 branch. I close this PR.

@remytms remytms closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants