9.0 attachment preview gs - #108
Conversation
…xed some errors displaying the attachments files.
…xed some errors displaying the attachments files.
…xed some errors displaying the attachments files.
…xed some errors displaying the attachments files.
|
Hey @cq-clearcorp, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
Please sign the CLA. |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Little comment, but code review + try on runbot correct. Most of the changes are from the new version library.
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/118/8.0 | ||
|
|
||
| For further information, please visit: |
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/118/8.0 |
|
Please squash all Transbot commits together and all your commits also. |
| @@ -1,11 +1,16 @@ | |||
| .openerp .oe_sidebar .oe_dropdown_menu li .oe-sidebar-attachment-preview | |||
| /*.openerp .oe_sidebar .oe_dropdown_menu li .oe_sidebar_attachment_preview | |||
There was a problem hiding this comment.
don't comment out stuff, remove if not necessary
| .click(this.on_attachment_preview); | ||
| this.update_preview_buttons(); | ||
| return result; | ||
| // return _super.apply(self, arguments); |
| if(openerp.attachment_preview.can_preview(extension)) | ||
| var $element = self.$('.oe_binary_preview'); | ||
| $element.unbind( "click" ); | ||
| if(can_preview(extension[0])) |
| self.view.datarecord.id), | ||
| extension, | ||
|
|
||
| ('data:application/'+extension[0]+';base64,'+ |
There was a problem hiding this comment.
why would you want to do this? With a few really big attachments, your browser becomes really inresponsive
| //]]> | ||
| </script> | ||
| <!-- load some small tweaks for the Odoo integration /--> | ||
| <script src="../../src/js/viewerjs_tweaks.js" type="text/javascript" charset="utf-8"></script> |
There was a problem hiding this comment.
if this is not needed any more, also delete the file
| } | ||
| return original_Viewer(plugin, parameters); | ||
| } | ||
| }; |
There was a problem hiding this comment.
you don't include this file any more, so it can go away i guess?
|
adding tests to have coverage at least not drop would be good |
Added secondary css jquery selector to include the preview buttons in community and enterprise versions.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
5 participants
No description provided.