[WIP] [14.0] [MIG] document_url - #304
Conversation
[MIG] document_url * bump version to 9.0.1.0.0 and make it installable * Update JS structure * Add css in order to be compliant with odoo style * Add a README.rst and OCA conventions * Improve selector * add fr.po for fr translation * open link with target='_blank'
Without this patch, when you hover on the menu item, its background color does not change, and its cursor is a text one. With this patch, the menu item styling matches those available in all surrounding menus.
Replace char © by word Copyright Change format in usage description
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/
Currently translated at 100.0% (14 of 14 strings) Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-document_url/
|
Hi @DavidBForgeFlow! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the |
|
@DavidBForgeFlow Tried it on runbot but not working, WIP? |
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
In addition, it will be necessary to change the javascript to adapt it to v14 and to extend the AttachmentBox component so that it works correctly.
| <templates id="template" xml:space="preserve"> | ||
| <t t-extend="mail.AttachmentBox"> | ||
| <t t-jquery="button.o_AttachmentBox_buttonAdd" t-operation="after"> | ||
| <button | ||
| type="button" | ||
| class="o_add_url_button btn btn-link" | ||
| t-on-click="_onClickAdd" | ||
| > | ||
| <i class="fa fa-plus-square" /> | ||
| Add URL | ||
| </button> | ||
| </t> | ||
| </t> | ||
| </templates> |
There was a problem hiding this comment.
| <templates id="template" xml:space="preserve"> | |
| <t t-extend="mail.AttachmentBox"> | |
| <t t-jquery="button.o_AttachmentBox_buttonAdd" t-operation="after"> | |
| <button | |
| type="button" | |
| class="o_add_url_button btn btn-link" | |
| t-on-click="_onClickAdd" | |
| > | |
| <i class="fa fa-plus-square" /> | |
| Add URL | |
| </button> | |
| </t> | |
| </t> | |
| </templates> | |
| <templates xml:space="preserve"> | |
| <t t-inherit="mail.AttachmentBox" t-inherit-mode="extension" owl="1"> | |
| <xpath expr="//button[hasclass('o_AttachmentBox_buttonAdd')]" position="after"> | |
| <button | |
| type="button" | |
| class="o_add_url_button btn btn-link" | |
| t-on-click="_onAddUrl" | |
| > | |
| <i class="fa fa-plus-square" /> | |
| Add URL | |
| </button> | |
| </xpath> | |
| </t> | |
| </templates> |
I think this change is necessary to show the "Add URL" button.
|
I think you can supersede, @victoralmau, as the contributor seems unresponsive. |
|
This PR should be closed, as @DavidBForgeFlow is no longer active and the PR was clearly superseded. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
13 participants
Standard migration to v14.