[MIG] document_url: Migration to 15.0 by matiasperalta1 · Pull Request #353 · OCA/knowledge

matiasperalta1 · 2022-06-16T17:18:39Z

No description provided.

[MIG] document_url * bump version to 9.0.1.0.0 and make it installable * Update JS structure * Add css in order to be compliant with odoo style * Add a README.rst and OCA conventions * Improve selector * add fr.po for fr translation * open link with target='_blank'

Without this patch, when you hover on the menu item, its background color does not change, and its cursor is a text one. With this patch, the menu item styling matches those available in all surrounding menus.

Replace char © by word Copyright Change format in usage description

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/

Currently translated at 100.0% (14 of 14 strings) Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/hr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-document_url/

pedrobaeza

See this image for my comments:

You can compare with the module in v14:

matiasperalta1 · 2022-07-18T17:38:52Z

@victoralmau Hi Victor. I contact you to ask you a question for this module. I'm migrating this module to v15 and I have seen that some changes were made by you in the migration to v14. I am trying to use the mimetype "application/link" but it is not working for me because I think it is invalid. How have you made it work?
Thank you very much and I hope your answer.

victoralmau · 2022-07-18T17:47:36Z

Hi, the approach is correct. I think the first thing to do is to add all the changes from v14 to the commit history. These changes are explained in the v14 migration PR: #306

[MIG] document_url: Migration to 14.0

TT30263

Define the add attachment and add URL buttons on the same line. Allow downloading of url type attachments by clicking on the icon or the name. Define the name of the url type attachments as links (allows to open it in a new tab). Hide the download button for url attachments. Force to set mimetype to "application/link" for url attachments. Displays a link icon for url attachments. TT30263

pedrobaeza · 2022-07-20T07:09:46Z

/ocabot migration document_url

OCA-git-bot · 2022-07-20T07:10:03Z

The migration issue (#308) has been updated to reference the current pull request.
however, a previous pull request was referenced : #337.
Perhaps you should check that there is no duplicate work.
CC : @JoelZilli

pedrobaeza · 2022-07-20T07:11:24Z

Everything is working now except having "Add attachments" and "Add URL" in 2 lines instead of one. Can you please check it?

pedrobaeza · 2022-07-20T07:12:33Z

The migration issue (#308) has been updated to reference the current pull request. however, a previous pull request was referenced : #337. Perhaps you should check that there is no duplicate work. CC : @JoelZilli

@legalsylvain it seems the new check is not correct, as the referenced PR is closed

victoralmau

Hi, thanks for the work.

Do not delete url.js file, make the necessary changes to reduce diff in commit
Squash administrative commits

Except for the comment in #353 (comment), everything would be correct.

pedrobaeza · 2022-07-24T10:16:42Z

Pre-commit is failing.

matiasperalta1 · 2022-07-25T13:52:25Z

@pedrobaeza Pre-commit Fixed

pedrobaeza · 2022-07-25T14:04:43Z

Thanks for the contribution

/ocabot merge nobump

OCA-git-bot · 2022-07-25T14:04:57Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-353-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-07-25T14:09:46Z

Congratulations, your PR was merged at 27f447a. Thanks a lot for contributing to OCA. ❤️

pedrobaeza and others added 26 commits March 30, 2022 14:59

[ADD] document_url: Module to attach URLs as documents

2e64a51

Slovene translations added

1214805

[FIX] document_url: Fix documentation

85832ef

OCA Transbot updated translations from Transifex

fe1ba4a

[FIX][document_url] Consistent styling.

ece60f5

Without this patch, when you hover on the menu item, its background color does not change, and its cursor is a text one. With this patch, the menu item styling matches those available in all surrounding menus.

[MIG] document_url: Migration to 11.0

c6efb5a

[MIG] document_url: Refactoring code

51554d4

Replace char © by word Copyright Change format in usage description

[UPD] Update document_url.pot

69158b6

[UPD] README.rst

a774474

Update translation files

eeaf78d

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[FIX] pylint/javascript-lint

b71687c

[MIG] document_url: Migration to 12.0

b2279d5

[UPD] README.rst

089aa35

[UPD] Update document_url.pot

37992ca

Update translation files

ffbcb9d

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/

[UPD] README.rst

1eef3c9

Translated using Weblate (Croatian)

75b1d91

Currently translated at 100.0% (14 of 14 strings) Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/hr/

[IMP] document_url: black, isort

03d7340

[MIG] document_url: Migration to 13.0

9df6ad8

[UPD] Update document_url.pot

b9f83b0

[UPD] README.rst

4578d70

Update translation files

b3154f0

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-document_url/

[FIX] document_url: Fix module dependencies.

9dc9b26

document_url 13.0.1.0.1

281809a

[IMP] document_url: pre-commit execution

21562ef

matiasperalta1 force-pushed the 15.0-t-25911-mnp branch 3 times, most recently from a6c6813 to 9044c8f Compare June 16, 2022 18:03

nicomacr mentioned this pull request Jun 28, 2022

15.0 mig document url #337

Closed

matiasperalta1 force-pushed the 15.0-t-25911-mnp branch from 9044c8f to a9abd97 Compare July 14, 2022 20:26

pedrobaeza requested changes Jul 17, 2022

View reviewed changes

DavidBForgeFlow and others added 3 commits July 18, 2022 16:19

[MIG] document_url: Migration to 14.0

129c79e

[MIG] document_url: Migration to 14.0

[MIG] document_url: Migration to 14.0

d3a0478

TT30263

matiasperalta1 force-pushed the 15.0-t-25911-mnp branch from a9abd97 to 411a6b6 Compare July 18, 2022 21:10

OCA-git-bot added this to the 15.0 milestone Jul 20, 2022

victoralmau suggested changes Jul 20, 2022

View reviewed changes

matiasperalta1 force-pushed the 15.0-t-25911-mnp branch from 411a6b6 to c9ef6bd Compare July 22, 2022 15:25

matiasperalta1 requested a review from pedrobaeza July 22, 2022 19:55

[MIG] document_url: Migration to 15.0

2b4aca3

matiasperalta1 force-pushed the 15.0-t-25911-mnp branch from c9ef6bd to 2b4aca3 Compare July 25, 2022 13:50

pedrobaeza approved these changes Jul 25, 2022

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jul 25, 2022

OCA-git-bot merged commit cc020fb into OCA:15.0 Jul 25, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 25, 2022

nicomacr deleted the 15.0-t-25911-mnp branch July 25, 2022 15:00

victoralmau mentioned this pull request Mar 1, 2023

[15.0][IMP] document_url: Add .scss + improve xpath selector (remove replace) #402

Merged

Uh oh!

Uh oh!

Conversation

matiasperalta1 commented Jun 16, 2022

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

matiasperalta1 commented Jul 18, 2022

Uh oh!

victoralmau commented Jul 18, 2022

Uh oh!

pedrobaeza commented Jul 20, 2022

Uh oh!

OCA-git-bot commented Jul 20, 2022

Uh oh!

pedrobaeza commented Jul 20, 2022

Uh oh!

pedrobaeza commented Jul 20, 2022

Uh oh!

victoralmau left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jul 24, 2022

Uh oh!

matiasperalta1 commented Jul 25, 2022

Uh oh!

pedrobaeza commented Jul 25, 2022

Uh oh!

OCA-git-bot commented Jul 25, 2022

Uh oh!

OCA-git-bot commented Jul 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants