[15.0][MIG] attachment_preview: Migration to version 15.0 by vancouver29 · Pull Request #363 · OCA/knowledge

vancouver29 · 2022-08-23T14:39:21Z

[15.0][MIG]attachment_preview

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

[FIX] Lint [FIX] lint and flake [ADD] tests [ADD] tests [ADD] tests [ADD] Tests [ADD] Package python-magic [ADD] Tests [FIX] Lint

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-11.0/knowledge-11.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-attachment_preview/

[REM] Old files [ADD] Magic to travis file [FIX] Nagivation refresh widget

vancouver29 · 2023-04-13T11:31:37Z

I needed to change
ids_to_browse = ids if isinstance(ids, collections.Iterable) else [ids]
to
ids_to_browse = ids if isinstance(ids, collections.abc.Iterable) else [ids]
in ir_attachment.py line 20 and 69

It seams that collections.Iterable is deprecated and should be replaced by collections.abc.Iterable

@HolgerNahrstaedt I just adjusted your suggestion collections.abc.Iterableinstead of collections.Iterable
@max3903 Can we merge this PR?

max3903 · 2023-04-13T15:22:38Z

/ocabot migration attachment_preview

max3903 · 2023-04-13T15:30:21Z

@HolgerNahrstaedt Can you update your review?

OCA-git-bot · 2023-04-13T15:47:35Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

HolgerNahrstaedt

Please see my suggestions with code examples. The change regarding the python code is ok.

HolgerNahrstaedt · 2023-04-17T07:09:49Z

+                    $target = $(event.currentTarget),
+                    split_screen = $target.attr("data-target") !== "new",
+                    attachment_id = this.attachment.id,
+                    attachment_extension = "pdf",


This should be removed and a get_attachment_extension rpc call should be used instead.

@HolgerNahrstaedt we still need the variables split_screen, attachment_id as the input for the rpc request. But you are right with the attachment_extension. It is unnecessary here, so I removed it per your suggestion.

HolgerNahrstaedt · 2023-04-17T07:13:07Z

+                    attachment_url = this.attachment.defaultSource;
+                active_attachment_id = attachment_id;
+
+                if (attachment_extension) {


The if else path Lines 250 to 272 can be replaced by:

rpc.query({ model: "ir.attachment", method: "get_attachment_extension", args: [attachment_id], }).then(function (extension) { self._showPreview( attachment_id, attachment_url, attachment_extension, extension, attachment_title, split_screen ); });

HolgerNahrstaedt · 2023-04-17T07:14:45Z

+                attachment_url,
+                attachment_extension,
+                attachment_title
+            );


A check if the extensions can be preview should be added

if (!canPreview(attachment_extension)) { return; }

it's added!

HolgerNahrstaedt · 2023-04-17T12:04:57Z

+            >
+                <div
+                    t-if="attachmentCard.attachment.downloadUrl"
+                    class="o_AttachmentCard_asideItem d-flex justify-content-center align-items-center ml4 o_attachment_preview"


o_attachment_preview should be removed here

it's removed!

HolgerNahrstaedt · 2023-04-17T12:05:05Z

+                </div>
+                <div
+                    t-if="attachmentCard.attachment.downloadUrl"
+                    class="o_AttachmentCard_asideItem d-flex justify-content-center align-items-center ml4 o_attachment_preview o_attachment_preview_new_tab"


o_attachment_preview should be removed here

it's removed!

…_attachment_preview

HolgerNahrstaedt

Sorry for the confusion, wrong account.

The changes look now good to me. Great work!

max3903 · 2023-04-18T13:44:27Z

/ocabot merge nobump

OCA-git-bot · 2023-04-18T13:44:36Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-363-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot · 2023-04-18T13:52:52Z

Congratulations, your PR was merged at 2429966. Thanks a lot for contributing to OCA. ❤️

hbrunn and others added 30 commits August 23, 2022 11:33

[ADD] preliminary port of attachment_preview

f7b7eff

[IMP] have titles work everywhere

47b1c9d

[FIX] don't depend on document, the relevant code still lives in web

bb7476e

[ADD] translations

ce6f4c8

[UPD] use viewerJS 0.5.4, incorporate new suported file types

e948e35

[FIX] readme 8.0 style

c56e671

Add OCA as author of OCA addons

fc07b12

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

fix travis (flake8)

54b64c2

Slovene translations added

d0b2e80

[UPD] use viewerjs 0.5.7

eb96be9

Translations and templates sync

1ecff09

[UPD] prefix versions with 8.0

43ce318

[MIG] Make modules uninstallable

2f4a4fd

[MIG] Rename manifest files

53dd6e9

remove obsolete .pot files [ci skip]

c6a4251

[MIG] attachment_preview: Migration to 11.0

b3c3f40

[FIX] Lint [FIX] lint and flake [ADD] tests [ADD] tests [ADD] tests [ADD] Tests [ADD] Package python-magic [ADD] Tests [FIX] Lint

[UPD] README.rst

1d35cfb

[UPD] Update attachment_preview.pot

5fd69b0

[FIX] Robustness when attachment not present

f2f0bfd

[IMP] attachment_preview: Split screen

713062b

[UPD] README.rst

bbde279

[UPD] Update attachment_preview.pot

c48c276

Update translation files

79b4957

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-11.0/knowledge-11.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-attachment_preview/

[FIX] pylint/javascript-lint

4c3d791

[UPD] Update attachment_preview.pot

9fdbbf1

Update translation files

d250f2a

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-11.0/knowledge-11.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-attachment_preview/

[UPD] README.rst

630e17f

[MIG] attachment_preview: Migration to 12.0

f4070f2

[REM] Old files [ADD] Magic to travis file [FIX] Nagivation refresh widget

[UPD] Update attachment_preview.pot

b2fcf34

[UPD] README.rst

07b3e28

[MIG] attachment_preview: Migration to 15.0

0bce1f3

vancouver29 force-pushed the 15.0-mig-attachment_preview branch from 17f2537 to 0bce1f3 Compare April 13, 2023 11:27

OCA-git-bot mentioned this pull request Apr 13, 2023

Migration to version 15.0 #308

Closed

11 tasks

max3903 changed the title ~~15.0 mig attachment preview~~ [15.0][MIG] attachment_preview: Migratn to version 15.0 Apr 13, 2023

max3903 self-assigned this Apr 13, 2023

max3903 changed the title ~~[15.0][MIG] attachment_preview: Migratn to version 15.0~~ [15.0][MIG] attachment_preview: Migration to version 15.0 Apr 13, 2023

max3903 approved these changes Apr 13, 2023

View reviewed changes

OCA-git-bot added the approved label Apr 13, 2023

OCA-git-bot added the ready to merge label Apr 13, 2023

HolgerNahrstaedt suggested changes Apr 17, 2023

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 17, 2023

HolgerNahrstaedt reviewed Apr 17, 2023

View reviewed changes

[IMP] attachment_preview: fix _onPreviewAttachment and remove class o…

e7c0e9d

…_attachment_preview

holgern approved these changes Apr 18, 2023 •

edited

Loading

View reviewed changes

HolgerNahrstaedt approved these changes Apr 18, 2023

View reviewed changes

OCA-git-bot added the approved label Apr 18, 2023

OCA-git-bot added the bot is merging ⏳ label Apr 18, 2023

OCA-git-bot merged commit 72440b8 into OCA:15.0 Apr 18, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 18, 2023

houzefa-abba mentioned this pull request Sep 29, 2023

[16.0][MIG] attachment_preview: Migration to 16.0 #434

Closed

Uh oh!

Uh oh!

Conversation

vancouver29 commented Aug 23, 2022

Uh oh!

vancouver29 commented Apr 13, 2023

Uh oh!

max3903 commented Apr 13, 2023

Uh oh!

max3903 commented Apr 13, 2023

Uh oh!

OCA-git-bot commented Apr 13, 2023

Uh oh!

HolgerNahrstaedt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vancouver29 Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HolgerNahrstaedt Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HolgerNahrstaedt left a comment

Choose a reason for hiding this comment

Uh oh!

max3903 commented Apr 18, 2023

Uh oh!

OCA-git-bot commented Apr 18, 2023

Uh oh!

OCA-git-bot commented Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

vancouver29 Apr 17, 2023 •

edited

Loading

HolgerNahrstaedt Apr 17, 2023 •

edited

Loading