[17.0][MIG] document_page_approval: Migration to 17.0#509
Merged
OCA-git-bot merged 44 commits intoNov 13, 2024
Conversation
(../7.0pageapproval/ rev 1) fix status bar in page approval (../7.0pageapproval/ rev 2) change approval workflow in page history and started to add showing approved page in normal page (../7.0pageapproval/ rev 3) show last approved content and aproved by (../7.0pageapproval/ rev 4) Fix bug on page creation (../7.0pageapproval/ rev 5) add status in history tree view (../7.0pageapproval/ rev 6) add a need approval field and hide the workflow when no approval needed (../7.0pageapproval/ rev 7) add access validation to approval (../7.0pageapproval/ rev 8) give rigth to Page aprover group on the page_history model and hide the button for unallowed group thought the security isn't enforced a the orm level (../7.0pageapproval/ rev 9) made invisible the prover group when not needed (../7.0pageapproval/ rev 10) add email to aprovers group's members (../7.0pageapproval/ rev 11)
[ADD] Translation file + french [FIX] employee_id field does not exist [FIX] user_email field deprecated [IMP] Split long lines [ADD] Images
fix act_draft and minor ui fix remove unused variables change order of xml data files
It should work but further errors could help understand what's going Commented other necessary part Add back workflow Add dependency to knowledge
[IMP] - Improved views to match document_page improvements. [IMP] - Added notification to followers when a new version is approved. [ADD] - Updated document_page_approval pot and added es translations. [IMP] - document_page_approval: Updated spanish translation.
…te module is installed.
* Lint error corrected * test improved * lint error corrected in test file * readme corrected * test improved * test of document page history workflow added * CI error corrected * dreipst comment * Migration to new api improved in model's file and data tag remove in xml file * code totally migrate to odoo 9.0 api * test bug fixed * test error fixed * Lint error improved
…ovements on documents (OCA#155)
* Rename classes and files to match model names, and removed workflow engine. * Some fields should be readonly if not in draft. * Allow Knowledge / Manager to edit previous history names and summary * Improve ux by adding user_has_drafts to document pages. * Changes because of implementation of active field on document_page * Add ir.rules for document.page.history * Allow to quickly cancel&draft from 'to approve' state * FIX BUG: am_i_approver was being run as sudo(), hence always giving the user Approving rights. * FIX hooks Because of default='draft' on the state field, state IS NULL wasn't selecting anything. Left the condition in case this is changed in the future.
[ADD] icon.png
Add the the group eployee to the rule "Change Request Global" to allow to the user with the rule "Change Request Approver" to create pages
[UPD] Update document_page_approval.pot
To pass test is necesary set approval required to False in demo data
[UPD] Update document_page_approval.pot [UPD] README.rst
TT36950 [UPD] Update document_page_approval.pot [UPD] README.rst
[UPD] Update document_page_approval.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/ Translated using Weblate (Italian) Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
Currently translated at 83.6% (51 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/hr/ Translated using Weblate (Croatian) Currently translated at 96.7% (59 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/hr/
Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
[UPD] Update document_page_approval.pot document_page_approval 16.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
Currently translated at 96.7% (59 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/ Translated using Weblate (Italian) Currently translated at 96.7% (59 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/ [UPD] Update document_page_approval.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
Currently translated at 96.7% (59 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
victoralmau
force-pushed
the
17.0-mig-document_page_approval
branch
from
November 12, 2024 12:18
e513bb0 to
f536e84
Compare
Member
|
/ocabot migration document_page_approval |
Contributor
|
The migration issue (#442) has not been updated to reference the current pull request because a previous pull request (#498) is not closed. |
Member
|
/ocabot migration document_page_approval |
max3903
approved these changes
Nov 12, 2024
carlos-lopez-tecnativa
suggested changes
Nov 12, 2024
Changes done: - Squash administrative commits - Purge translations - Remove ir.model.access.csv file - Improve tests (change to setUpClass) - Replace name_get() to _compute_display_name() (document_page) - Remove readonly=1 (redudant, it already is) defined in approved_uid and approved_date fields in views - Restore readonly=1 to the state field - Remove duplicate Back to draft button TT51529
victoralmau
force-pushed
the
17.0-mig-document_page_approval
branch
from
November 12, 2024 16:38
f536e84 to
6438cd2
Compare
carlos-lopez-tecnativa
approved these changes
Nov 12, 2024
Member
|
/ocabot merge nobump |
1 similar comment
Member
|
/ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at acd3a0e. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #498
Migration to 17.0
Changes done:
ir.model.access.csvfile [MIG][17.0] document_page_approval #498 (comment)document_page: Replacename_get()to_compute_display_name()[MIG][17.0] document_page_approval #498 (comment)readonly=1(redudant, it already is) defined inapproved_uidandapproved_datefields in viewsreadonly=1to the state fieldPlease @pilarvargas-tecnativa and @carlos-lopez-tecnativa can you review it?
@Tecnativa TT51529