[18.0][MIG] document_url: Migration to 18.0#542
Merged
Conversation
[MIG] document_url * bump version to 9.0.1.0.0 and make it installable * Update JS structure * Add css in order to be compliant with odoo style * Add a README.rst and OCA conventions * Improve selector * add fr.po for fr translation * open link with target='_blank'
Without this patch, when you hover on the menu item, its background color does not change, and its cursor is a text one. With this patch, the menu item styling matches those available in all surrounding menus.
Replace char © by word Copyright Change format in usage description
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/
Currently translated at 100.0% (14 of 14 strings) Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-document_url/
[MIG] document_url: Migration to 14.0
Define the add attachment and add URL buttons on the same line. Allow downloading of url type attachments by clicking on the icon or the name. Define the name of the url type attachments as links (allows to open it in a new tab). Hide the download button for url attachments. Force to set mimetype to "application/link" for url attachments. Displays a link icon for url attachments. TT30263
Currently translated at 100.0% (17 of 17 strings) Translation: knowledge-17.0/knowledge-17.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_url/sv/
Currently translated at 100.0% (17 of 17 strings) Translation: knowledge-17.0/knowledge-17.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_url/ca/
Fix download atachment widget. Document_url when activated causes error when opening attachment link on the chatter window This commit (odoo/odoo@366676c) move download buttons into a sub-component. I modified the module behavior to use canDownload() method instead of adding a t-if in the view and prevent the chatter component from breaking when the message has attachments.
13 tasks
Member
|
/ocabot migration document_url |
pedrobaeza
reviewed
May 8, 2025
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
On runboat, I see 2 icons for the exact same purpose:
| - Ernesto Tejeda | ||
| - Manuel Calero | ||
| - Víctor Martínez | ||
| - Matias Peralta - Adhoc SA |
Member
There was a problem hiding this comment.
This one should be deindented, as it doesn't belong to Tecnativa.
| <field name='target'>new</field> | ||
| <field name='view_mode'>form</field> | ||
| </record> | ||
| <data> |
Member
There was a problem hiding this comment.
Remove data tag and deindent the rest (you can do it on the "pre-commit auto-fixes" one for reducing the noise).
BhaveshHeliconia
force-pushed
the
18.0-mig-document_url
branch
from
May 27, 2025 06:29
b1df567 to
15ec24a
Compare
Contributor
Author
|
@pedrobaeza Please Review.it's done. |
pedrobaeza
reviewed
May 28, 2025
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
It's better now, thanks, but still one comment pending and another thing I have discovered:
Please do it that removing the link, the name is put on the confirmation dialog.
TT56040
| - Ernesto Tejeda | ||
| - Manuel Calero | ||
| - Víctor Martínez | ||
| - Matias Peralta - Adhoc SA |
BhaveshHeliconia
force-pushed
the
18.0-mig-document_url
branch
from
May 28, 2025 09:29
15ec24a to
e497ab1
Compare
Contributor
Author
|
@pedrobaeza, Please Review.it's fixed. |
Member
|
/ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 56a0156. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.