[9.0] document_page by naousse · Pull Request #76 · OCA/knowledge

naousse · 2015-10-22T07:08:14Z

No description provided.

pedrobaeza · 2015-10-22T07:10:41Z

This should be in RST format with name README.rst and follow this template: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst

naousse · 2015-10-22T07:12:45Z

OK. I will do it

dreispt · 2015-10-22T07:20:36Z

Remove the description key

naousse · 2015-10-25T17:28:18Z

@dreispt @pedrobaeza , please i have fixed some errors that were in my pull request. Please can you check now if the module are OK.

max3903 · 2015-10-25T18:55:22Z

... make sure to have it in your addons list.

max3903 · 2015-10-30T02:29:04Z

@naousse Please remove the extra =

naousse · 2015-10-30T17:56:52Z

I removed the extra = in readme.rst and the knowledge module

dreispt · 2015-11-01T15:46:42Z

Remove size

max3903 · 2015-11-13T23:29:21Z

@naousse Needs rebasing and fixing ;)

max3903 · 2015-11-13T23:30:57Z

@naousse You need an extra line before the list, otherwise rendering fails.

dreispt · 2015-11-19T10:50:45Z

It's not advised to the docstrings on python files. Add to Model classes instead.

dreispt · 2015-11-19T10:57:23Z

Other than some minor notes, it has my 👍

max3903 · 2015-11-22T19:52:42Z

Replace {project_repo} with knowledge

max3903 · 2015-12-04T18:13:19Z

@naousse Please take @dreispt suggestions to fix the module.

A screenshot with its path in the images keyword of the __openerp__.py would be nice, like here:
https://github.com/odoo/odoo/blob/9.0/addons/account/__openerp__.py#L17

…" corrected

max3903 · 2015-12-08T21:27:56Z

👍

[9.0] document_page

pedrobaeza reviewed Oct 22, 2015
View reviewed changes

dreispt reviewed Oct 22, 2015
View reviewed changes

Comment thread document_page/__openerp__.py Outdated

dreispt Oct 22, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the description key

max3903 added the needs fixing label Oct 22, 2015

max3903 added this to the 9.0 milestone Oct 22, 2015

max3903 reviewed Oct 25, 2015
View reviewed changes

Comment thread document_page/README.rst Outdated

max3903 Oct 25, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... make sure to have it in your addons list.

max3903 mentioned this pull request Oct 30, 2015

Migration to version 9 #71

Closed

9 tasks

max3903 reviewed Oct 30, 2015
View reviewed changes

Comment thread document_page/README.rst Outdated

max3903 Oct 30, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naousse Please remove the extra =

max3903 changed the title ~~9.0 document page module migration~~ [9.0] document_page Oct 30, 2015

pedrobaeza mentioned this pull request Oct 30, 2015

Migration to version 9.0 #72

Closed

13 tasks

dreispt reviewed Nov 1, 2015
View reviewed changes

Comment thread document_page/models/document_page_history.py Outdated

dreispt Nov 1, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove size

max3903 reviewed Nov 13, 2015
View reviewed changes

naousse force-pushed the 9.0-document_page branch from e910798 to 0fa0920 Compare November 18, 2015 19:38

[ADD] Document_page

0901b0f

naousse force-pushed the 9.0-document_page branch from 0fa0920 to 0901b0f Compare November 18, 2015 19:44

dreispt reviewed Nov 19, 2015
View reviewed changes

max3903 reviewed Nov 22, 2015
View reviewed changes

Comment thread document_page/README.rst Outdated

max3903 Nov 22, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace {project_repo} with knowledge

max3903 added needs fixing and removed needs review labels Nov 22, 2015

Error corrected

c380a68

naousse added 13 commits December 7, 2015 14:19

@DreiPst not corrected

d92441c

images added

e3dc6d8

__openerp__.py error connected

1c72749

test writed in python

fc55660

pylint error in test file corrected

53870f0

yaml test removed from __openerp__.py

8b52e66

flake8 error "E126 continuation line over-indented for hanging indent…

f978d2a

…" corrected

code coverage improve

e49136b

code coverage rogress

086e98a

test code coverage progress

8390365

test code coverage progress

9dbe6eb

Test corrected

72f9a4b

flake8 error corrected

6f5c619

max3903 pushed a commit that referenced this pull request Dec 8, 2015

Merge pull request #76 from naousse/9.0-document_page

837ab83

[9.0] document_page

max3903 merged commit 837ab83 into OCA:9.0 Dec 8, 2015

yvaucher removed the needs fixing label Dec 8, 2015

Uh oh!

Uh oh!

Conversation

naousse commented Oct 22, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naousse commented Oct 22, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naousse commented Oct 25, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naousse commented Oct 30, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max3903 commented Nov 13, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dreispt commented Nov 19, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max3903 commented Dec 4, 2015

Uh oh!

max3903 commented Dec 8, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants