[9.0] document_page_approval

[naousse]

No description provided.

[max3903]

@naousse There are 2 modules in your pull request. Please split them in 2 branches and pull requests.

[elicoidal]

s/oder/other
add period

[max3903]

@naousse Needs rebasing. Let me know if you need help.

https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request#how-do-i-rebase

[max3903]

@naousse You have 2 extra '=' here.

[max3903]

@naousse If you can write tests to remain over 80%, that would be enough for me to accept the module.

[naousse]

OK. I'm looking how to write some workflow test.
Please why does runbot failed

[max3903]

@naousse It's not specific to your PR. It happened on all OCA ones during the last 24 hours. It seems to be a problem with the database. I will check it later today.

[max3903]

👍

[dreispt]

Don't use module docstrings

[max3903]

@dreispt let's merge it ?

[max3903]

@sysadminmatmoz, @gborelli can you review this PR please?

[lmignon]

Why don't you decorate methods iterating on self for page in self with @api.multi?

[naousse]

I added the decorator @api.multi. But i don't know why it is necessary.

[max3903]

Thanks @lmignon and @bealdav. I will work on that with @naousse.
Please RT the link to your PR you want me to review.

[bealdav]

It's nice as it, but in fact you can save bytes because in init you have no real code, just import as ascii. Then your file could only have 1 line.

[bealdav]

@max3903 , I have to test to complet my review when runbot 'll have finished it build, but you can make a review here OCA/product-attribute#52, thanks
EDIT: runbot has failed

[lmignon]

@max3903 You already do so much for the community. My review is just a way to contribute to what the OCA give me for free.

[bealdav]

@max3903 @lmignon, you're right so much work to animate community and publish info on https://odoo-community.org. Thanks to the whole community

[lmignon]

IMO, the code can be shortened

...
template = self.env.ref(''document_page_approval.email_template_new_draft_need_approval")
for page in self:
    if page.is_parent_approval_required:
        template.send_mail(page.id, force_send=True)
...

[lmignon]

@naousse can you chek in your code all the methods that iterate on self or expect that self is an active_record. In these cases you should add the appropriate decorator api.multi.

[lmignon]

👍 thank you @naousse