Skip to content

[18.0][MIG] product_sticker#2011

Merged
OCA-git-bot merged 8 commits intoOCA:18.0from
moduon:18.0-mig-product_sticker
Jul 4, 2025
Merged

[18.0][MIG] product_sticker#2011
OCA-git-bot merged 8 commits intoOCA:18.0from
moduon:18.0-mig-product_sticker

Conversation

@Shide
Copy link
Contributor

@Shide Shide commented Jul 2, 2025

Straight forward migration

MT-10779 @moduon @yajo @chienandalu @u0f @andrii9090 please review if you want 😄

@Shide Shide force-pushed the 18.0-mig-product_sticker branch 2 times, most recently from 1b6a1bc to f6ded6f Compare July 2, 2025 08:36
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & functional review.

@Shide Shide force-pushed the 18.0-mig-product_sticker branch from f6ded6f to 67b261f Compare July 2, 2025 09:16
@Shide Shide requested a review from yajo July 2, 2025 09:16
@rafaelbn
Copy link
Member

rafaelbn commented Jul 2, 2025

/ocabot migration product_sticker

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 2, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 2, 2025
71 tasks
Copy link
Contributor

@Andrii9090-tecnativa Andrii9090-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & functional review.

Copy link

@u0f u0f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & functional review.

@Shide
Copy link
Contributor Author

Shide commented Jul 3, 2025

@HaraldPanten please, can you review like you do in v16? 🫶

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🏼

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @rafaelbn you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@rafaelbn
Copy link
Member

rafaelbn commented Jul 4, 2025

🙏 Please @OCA/product-maintainers could you merge this one? We are migrating more modules which depends on this one in diferentes repositories.

We are maintainers of this module

Thank you! 💙

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using this module, but it has enough reviews.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-2011-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 290478d into OCA:18.0 Jul 4, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f310fc7. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 18.0-mig-product_sticker branch July 4, 2025 08:30
victoralmau pushed a commit to Tecnativa/product-attribute that referenced this pull request Jul 10, 2025
Signed-off-by HaraldPanten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants