[18.0][MIG] auth_oidc: Migration to 18.0 by ap-wtioit · Pull Request #705 · OCA/server-auth

ap-wtioit · 2024-10-09T11:10:05Z

update manifest, add README, update requirements.txt

Add some install instructions and configuration instructions for keycloak.

Avoid replacing the access token by the id token. This may cause confusion. Copy a little piece of code from auth_oauth() method, to make the code easier to follow, and prepare for implementing the authorization code flow.

This is not a recommended scenario, but this prepares the code for using PKCE

…decode

inspired by OCA#336

create an upstream merge request after OCA#393 is merged

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-17.0/server-auth-17.0-auth_oidc Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_oidc/

Currently translated at 100.0% (20 of 20 strings) Translation: server-auth-17.0/server-auth-17.0-auth_oidc Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_oidc/zh_CN/

ap-wtioit · 2024-10-09T11:10:40Z

/ocabot migration auth_oidc

OCA-git-bot · 2024-10-09T11:10:48Z

Sorry @ap-wtioit you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

sbidoul · 2024-10-09T12:35:45Z

/ocabot migration auth_oidc

sbidoul · 2024-10-09T12:46:41Z

I compared with 17, and it's identical.

Compared to 16, there are a couple of PR's that landed there that were never ported to 17 (#573, #650) - not saying you need to do it, just a note.

hparfr

LGTM (not tested yet)

sbidoul · 2024-10-23T12:50:37Z

Happy to merge this as soon as someone confirms it has been functionally tested.

wtaferner

Functionally tested within our own OAuth Provider Infrastructure and logged in successfully on the target test instance with OpenID

sbidoul · 2024-10-23T13:12:33Z

/ocabot merge nobump

OCA-git-bot · 2024-10-23T13:12:41Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-705-by-sbidoul-bump-nobump, awaiting test results.

hparfr · 2024-10-23T13:14:32Z

Tested as well with keyloack; works as expected.

OCA-git-bot · 2024-10-23T13:16:49Z

Congratulations, your PR was merged at 25c76aa. Thanks a lot for contributing to OCA. ❤️

andreschenkels and others added 30 commits October 9, 2024 12:35

[ADD] auth_oidc module

0e91d23

Adapt to OCA standards

6c69d61

update manifest, add README, update requirements.txt

auth_oidc: improve docs

4e5a9b4

Add some install instructions and configuration instructions for keycloak.

[MIG] auth_oidc: update dotfiles

467517c

[MIG] auth_oidc from 10.0

fa18a6c

auth_oidc: simplify and use "id_token token"

85c0216

Avoid replacing the access token by the id token. This may cause confusion. Copy a little piece of code from auth_oauth() method, to make the code easier to follow, and prepare for implementing the authorization code flow.

auth_oidc: _get_key and _map_token_values are not model methods

ea43cf1

auth_oidc: cache _get_key

175bbc0

auth_oidc: add authorization code flow

5b03dae

auth_oidc: separate field for jwks uri

421abad

auth_oidc: additional error logging

64db402

auth_oidc: add author and maintainer

c68ba4d

auth_oidc: improve docs, mention implicit flow is not recommended

13671f9

auth_oidc: better nonce

1bd69a1

auth_oidc: make client secret optional

1f0af05

This is not a recommended scenario, but this prepares the code for using PKCE

auth_oidc: add PKCE support

3089ef1

auth_oidc: demo data and basic test

d902ea9

auth_oidc: slightly more robust parsing of claim mapping

7953262

auth_oidc: split long method

6d587ff

[UPD] Update auth_oidc.pot

2852bb3

[MIG] auth_oidc: Migration to 14.0

94767df

[FIX] auth_oidc: Fix werkzeug deprecated warning for url_encode, url …

b0c8ef9

…decode

[MIG] auth_oidc: Migration to 15.0

cb28f54

[16.0][MIG] auth_oidc: Migration to 16.0

748cd1e

[IMP] add AzureAD code flow provider

1f60335

Added translation using Weblate (Spanish)

ac4a138

[DOC] auth_oidc: fix images and convert to md

09bf51d

Added translation using Weblate (Italian)

f029479

[FIX] auth_oidc: set user_id for auth_oauth

27f964e

inspired by OCA#336

[FIX] auth_oidc: support keys without kid

3c025b6

create an upstream merge request after OCA#393 is merged

ap-wtioit and others added 9 commits October 9, 2024 12:35

[IMP] auth_oidc: update documentation for 16.0.1.1.0

a463f61

[IMP] auth_oidc: pre-commit fixes

0d84d9b

[MIG] auth_oidc: Migration to 17.0

b6de18f

[UPD] Update auth_oidc.pot

726c340

[BOT] post-merge updates

5f6975e

Update translation files

cd39ddd

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-17.0/server-auth-17.0-auth_oidc Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_oidc/

Added translation using Weblate (Chinese (Simplified) (zh_CN))

df1a17f

Translated using Weblate (Chinese (Simplified) (zh_CN))

e2da3ee

Currently translated at 100.0% (20 of 20 strings) Translation: server-auth-17.0/server-auth-17.0-auth_oidc Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_oidc/zh_CN/

[IMP] auth_oidc: pre-commit auto fixes

fbc0116

ap-wtioit force-pushed the 18.0-mig-auth_oidc branch from 15acbe0 to 52fe221 Compare October 9, 2024 11:21

[MIG] auth_oidc: Migration to 18.0

bebe25c

ap-wtioit force-pushed the 18.0-mig-auth_oidc branch from 52fe221 to bebe25c Compare October 9, 2024 11:53

ap-wtioit mentioned this pull request Oct 9, 2024

Migration to version 18.0 #698

Open

23 tasks

OCA-git-bot added this to the 18.0 milestone Oct 9, 2024

hparfr approved these changes Oct 23, 2024

View reviewed changes

wtaferner approved these changes Oct 23, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 23, 2024

OCA-git-bot added the bot is merging ⏳ label Oct 23, 2024

OCA-git-bot merged commit 06c1bed into OCA:18.0 Oct 23, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[18.0][MIG] auth_oidc: Migration to 18.0#705

[18.0][MIG] auth_oidc: Migration to 18.0#705
OCA-git-bot merged 40 commits intoOCA:18.0from
ap-wtioit:18.0-mig-auth_oidc

ap-wtioit commented Oct 9, 2024

Uh oh!

ap-wtioit commented Oct 9, 2024 •

edited

Loading

Uh oh!

OCA-git-bot commented Oct 9, 2024

Uh oh!

sbidoul commented Oct 9, 2024

Uh oh!

sbidoul commented Oct 9, 2024

Uh oh!

hparfr left a comment

Uh oh!

sbidoul commented Oct 23, 2024

Uh oh!

wtaferner left a comment

Uh oh!

sbidoul commented Oct 23, 2024

Uh oh!

OCA-git-bot commented Oct 23, 2024

Uh oh!

hparfr commented Oct 23, 2024

Uh oh!

OCA-git-bot commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Uh oh!

Conversation

ap-wtioit commented Oct 9, 2024

Uh oh!

ap-wtioit commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Oct 9, 2024

Uh oh!

sbidoul commented Oct 9, 2024

Uh oh!

sbidoul commented Oct 9, 2024

Uh oh!

hparfr left a comment

Choose a reason for hiding this comment

Uh oh!

sbidoul commented Oct 23, 2024

Uh oh!

wtaferner left a comment

Choose a reason for hiding this comment

Uh oh!

sbidoul commented Oct 23, 2024

Uh oh!

OCA-git-bot commented Oct 23, 2024

Uh oh!

hparfr commented Oct 23, 2024

Uh oh!

OCA-git-bot commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

ap-wtioit commented Oct 9, 2024 •

edited

Loading