Skip to content

[18.0][MIG] auth_jwt: Migration to 18.0 #752

Merged
OCA-git-bot merged 48 commits intoOCA:18.0from
kencove:18.0-mig-auth_jwt
Aug 26, 2025
Merged

[18.0][MIG] auth_jwt: Migration to 18.0 #752
OCA-git-bot merged 48 commits intoOCA:18.0from
kencove:18.0-mig-auth_jwt

Conversation

@dnplkndll
Copy link
Contributor

@dnplkndll dnplkndll commented Jan 16, 2025

No description provided.

@dnplkndll dnplkndll changed the title [18.0][MIG] auth_jwt [18.0][MIG] auth_jwt: Migration 18.0 Jan 16, 2025
@dnplkndll dnplkndll changed the title [18.0][MIG] auth_jwt: Migration 18.0 [18.0][MIG] auth_jwt: Migration to 18.0 Jan 16, 2025
@dnplkndll dnplkndll mentioned this pull request Jan 16, 2025
Merged
2 tasks
@lmignon
Copy link
Contributor

lmignon commented Jan 17, 2025

/ocabot migration auth_jwt

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 17, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 17, 2025
Open
23 tasks
@dnplkndll dnplkndll mentioned this pull request Jan 17, 2025
Closed
@sbidoul
Copy link
Member

sbidoul commented Jan 18, 2025

Thanks for working on this. Could you re-do the migration based on the merged 17.0 version? Your migration commit is ok, but the history of the 17.0 branch you started with is a bit messy and has been cleaned-up since.

kobros-tech
kobros-tech approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@kobros-tech kobros-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmignon
@sbidoul

could you review this PR, we have merged migration for 17.0 and we can migrate it for 18.0

ChuwenSun
ChuwenSun approved these changes Feb 3, 2025
View reviewed changes
Copy link

@ChuwenSun ChuwenSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dnplkndll dnplkndll force-pushed the 18.0-mig-auth_jwt branch 2 times, most recently from d5e8550 to bda753a Compare February 15, 2025 02:02
@dnplkndll
Copy link
Contributor Author

dnplkndll commented Feb 15, 2025

Thanks for working on this. Could you re-do the migration based on the merged 17.0 version? Your migration commit is ok, but the history of the 17.0 branch you started with is a bit messy and has been cleaned-up since.

@sbidoul rebased and squashed the bot commits.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 15, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dnplkndll
Copy link
Contributor Author

dnplkndll commented Mar 19, 2025

any update requested or this should be ready to merge

@kobros-tech
Copy link
Contributor

kobros-tech commented Mar 20, 2025

@lmignon
@sbidoul

LGTM!

@sbidoul
Copy link
Member

sbidoul commented Mar 20, 2025

I think there is a problem with the _authenticate override in ir_http.py. The upstream method has changed and the arguments don't match anymore.

I'm surprised this would work correctly.

I'd say we should rather override _authenticate_explicit but I'm not sure.

sbidoul
sbidoul requested changes Mar 20, 2025
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in my previous comment.

@sbidoul
Copy link
Member

sbidoul commented Mar 20, 2025

Ah, can you also migrate auth_jwt_demo in this same PR because that's where all the tests are.

@kobros-tech kobros-tech mentioned this pull request Apr 1, 2025
Closed
1 task
@kobros-tech
Copy link
Contributor

kobros-tech commented Apr 1, 2025

Ah, can you also migrate auth_jwt_demo in this same PR because that's where all the tests are.

@sbidoul
Hi auth_jwt_demo is open now for review, #780

@kobros-tech kobros-tech mentioned this pull request Apr 2, 2025
Closed
3 tasks
@sbidoul
Copy link
Member

sbidoul commented May 15, 2025

I commented on the auth_jwt_demo migration.

Have had a chance to look at #752 (comment) ?

sbidoul and others added 21 commits August 25, 2025 04:37
@sbidoul @kobros-tech
auth_jwt: clarify exceptions
4a06a42 
Distinguish errors that lead to a 401
from internal configuration errors.
@sbidoul @kobros-tech
auth_jwt: minor refactoring
356bdf9
@sbidoul @kobros-tech
[IMP] auth_jwt: refactor
c19e1a9 
Extract _parse_bearer_authorization function for easier reuse by fastapi_auth_jwt
@sbidoul @kobros-tech
[FIX] auth_jwt: don't use public mode if a cookie is present
5c7ce82
@sbidoul @kobros-tech
[IMP] auth_jwt: check cookie_name is present in cookie mode
3adb205
@kobros-tech
[UPD] Update auth_jwt.pot
c1ad5a6
@OCA-git-bot @kobros-tech
[UPD] README.rst
55f6c40
@OCA-git-bot @kobros-tech
auth_jwt 16.0.1.1.0
b4ba8b0
@Ivorra78 @kobros-tech
Added translation using Weblate (Spanish)
d468520
@Ivorra78 @kobros-tech
Translated using Weblate (Spanish)
1d929b4 
Currently translated at 100.0% (64 of 64 strings)

Translation: server-auth-16.0/server-auth-16.0-auth_jwt
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/es/
@OCA-git-bot @kobros-tech
[UPD] README.rst
f0fa200
@rbellanova @kobros-tech
Added translation using Weblate (Italian)
0bc67e5
@rbellanova @kobros-tech
Translated using Weblate (Italian)
b9ad174 
Currently translated at 89.0% (57 of 64 strings)

Translation: server-auth-16.0/server-auth-16.0-auth_jwt
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
@mymage @kobros-tech
Translated using Weblate (Italian)
c75c67f 
Currently translated at 100.0% (64 of 64 strings)

Translation: server-auth-16.0/server-auth-16.0-auth_jwt
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
@francesco-ooops @kobros-tech
Translated using Weblate (Italian)
4e5a8d6 
Currently translated at 100.0% (64 of 64 strings)

Translation: server-auth-16.0/server-auth-16.0-auth_jwt
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
@MikeAelbrecht @kobros-tech
[MIG] auth_jwt: Migration to 17.0
208f80e
@kobros-tech
[UPD] Update auth_jwt.pot
88c5a1f
@OCA-git-bot @kobros-tech
[BOT] post-merge updates
0700ed5
@weblate @kobros-tech
Update translation files
222c104 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-auth-17.0/server-auth-17.0-auth_jwt
Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_jwt/
@dnplkndll @kobros-tech
[IMP] auth_jwt: pre-commit auto fixes
a888c3c
@dnplkndll @kobros-tech
[MIG] auth_jwt: Migration to 18.0
936aa6a
@kobros-tech
Copy link
Contributor

kobros-tech commented Aug 26, 2025

@sbidoul

I think it is very ready now?

@yvaucher
Copy link
Member

yvaucher commented Aug 26, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 26, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-752-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8f93c1c into OCA:18.0 Aug 26, 2025
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 26, 2025

Congratulations, your PR was merged at 5afea9a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbidoul sbidoul sbidoul requested changes

+3 more reviewers

@grindtildeath grindtildeath grindtildeath approved these changes

@ChuwenSun ChuwenSun ChuwenSun approved these changes

@kobros-tech kobros-tech kobros-tech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.