Skip to content

[17.0][FIX] auth_saml: fix sending password change mail when blanking password #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincent-hatakeyama wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][FIX] auth_saml: fix sending password change mail when blanking password #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion auth_saml/models/res_users_saml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,6 @@ def create(self, vals_list):
# Redefined to remove password if necessary
result = super().create(vals_list)
if not self.env["res.users"].allow_saml_and_password():
result.mapped("user_id").write({"password": False})
# Avoid sending a security mail by using this method instead of a write
result.mapped("user_id")._set_password_blank()
return result
1 change: 1 addition & 0 deletions auth_saml/readme/newsfragments/+no-password-mail.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix sending a mail when configuring SAML for a user.