Skip to content

[19.0][FIX] impersonate_login: preserve attachment creator ownership #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdgellatly wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[19.0][FIX] impersonate_login: preserve attachment creator ownership #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions impersonate_login/models/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ class BaseModel(models.AbstractModel):

def _prepare_create_values(self, vals_list):
result_vals_list = super()._prepare_create_values(vals_list)
# Keep core attachment access semantics intact.
# For temporary/generated attachments (often without res_model/res_id),
# read access falls back to creator ownership. Rewriting create_uid to
# the original impersonator can make the active impersonated user lose
# access immediately in the same flow (e.g. compose email after report).
if self._name == "ir.attachment":
return result_vals_list
if (
request
and request.session.get("impersonate_from_uid")
Expand All @@ -23,6 +30,8 @@ def _prepare_create_values(self, vals_list):
def write(self, vals):
"""Overwrite the write_uid with the impersonating user"""
res = super().write(vals)
if self._name == "ir.attachment":
return res
if (
request
and request.session.get("impersonate_from_uid")
Expand Down