[IMP] purge uninstalled unavailable modules in bulk - #1316
Merged
Conversation
sebalix
approved these changes
Jul 17, 2018
| @api.model | ||
| def find(self): | ||
| res = [] | ||
| purge_lines = self.env['cleanup.purge.line.module'] |
Contributor
There was a problem hiding this comment.
Is it worth adding .browse() for clarity (empty recordset)?
👍 I have experienced slow processes when cleaning databases, maybe it was the cause.
Member
Author
There was a problem hiding this comment.
I used to add the .browse([]), but meanwhile I see this used as idiom for an empty recordset very often, so if you don't insist, I'd like to keep it this way
Contributor
There was a problem hiding this comment.
I don't, it was a coding-style question!
pedrobaeza
approved these changes
Oct 10, 2018
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (8.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this, you'll have to wait unnecessarily long for the wizard to start in case there are a lot of uninstallable modules to purge, because purging causes a full registry reload, which costs a lot of time. Doing it in bulk will cause only one registry reload for all modules.