[12.0] [WIP] database_cleanup: migration to 12.0

[mart-e]

As part of the hacktoberfest, I am starting to migrate the module database_cleanup to 12.0 (hopefully nobody is working on it yet).

• update version number
• apply new README rules
• squash OCA Transbot
• migration scripts
• date(time)
• label/filter
• SASS
• test

[pedrobaeza]

Great! No, nobody is working on this yet, so I assign you in #1368

[mart-e]

@pedrobaeza should be good now !

[gustavovalverde]

Teste with a module migration use case from V11, which was also done in v12. Almost all seems like working OK, except for a weird behavior which I couldn't reproduce again when Purging all columns; after doing that it started complaining that my user (admin 1) didn't have enough priviliges when clicking on all menus. After a refresh a 403 Forbidden was raised.

After restoring a snapshot and doing the process again, this did not happened; and everything seems working as expected.

[gustavovalverde]

Found the culprit; it's the password column from res.users. If purged it locks you out of the system. cc: @mart-e @pedrobaeza

[paulius-sladkevicius]

I've tested it out on the v12, works well. However I found password and password_crypt in the list of columns that wants to purge, so @gustavovalverde is right.

[pedrobaeza]

#1507 should be included here.

[bealdav]

@pedrobaeza Don't you think we can merge and add a comment in roadmap to cherry pick v11 changes .

[gustavovalverde]

@bealdav this shouldn't be merged until the passwords issue is solved (at least): #1408 (comment)

P.D.: I'm using it already, with this PR, knowing that I have to remove the password table from being purged. But someone can have a really bad moment not knowing this.

[pedrobaeza]

Well, that comment means to not do it ever, and that changes are very important, even possibly solving @gustavovalverde's issue. If you want to retake the migration and add that PR, it's very straight-forward.

[oca-clabot]

Hey @mart-e, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

• Stefan Rijnhart stefan@therp.nl (no github login found)

Appreciation of efforts,
OCA CLAbot

[pedrobaeza]

@mart-e has just pushed an updated branch. Please check your issue, @gustavovalverde

[mart-e]

Hi,

Sorry for the lack of replies. I will try to fix the remaining issue.

[pedrobaeza]

Thanks!

[mart-e]

I have also picked the commits from #1507, I hope it was the only ones.

[gustavovalverde]

@bealdav and @paulius-sladkevicius could you guys check and approve if everything is working as expected?