[10.0] [FIX] users_ldap_populate special characters

[r-hede]

Hi,

Currently, you can not use special characters in the username, password, or LDAP base.

To fix that, you just have to modify the lines 126 to 130 of the file users_ldap.py like this:

conn.simple_bind_s(conf['ldap_binddn'].encode('utf-8') or '',
                   conf['ldap_password'].encode('utf-8') or '')
results = conn.search_st(conf['ldap_base'].encode('utf-8'), ldap.SCOPE_SUBTREE,
                         ldap_filter.encode('utf8'), None,
                         timeout=60)

Best regards,

Robin Hède.

[NL66278]

Please fix this error in travis (not caused by your PR, but apparently existing issue):

************* Module users_ldap_populate.models.users_ldap
users_ldap_populate/models/users_ldap.py:90: [C8107(translation-required), CompanyLDAP.action_populate] String parameter on "UserError" requires translation. Use _('Unable to process user with login %s')

[NL66278]

👍 LGTM, but needs one extra change to satisfy travis.

[NL66278]

👍 LGTM

[r-hede]

Is there any other steps I've to take to get this pull request reviewed and merged?

[NL66278]

I will ping some people I know. I do not have any special authority in this repository.

@StefanRijnhart @hbrunn

[hbrunn]

@r-hede the best way to get your stuff reviewed is reviewing yourself in the same repository

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[StefanRijnhart]

Couple of questions: Why are there changes in all these translation files? Don't we leave those to the automatic Weblate integration? And, why are there arbitrary whitespace changes? Between those two, I'm having trouble to spot the actual fix. So if you could give me a pointer to that, that would be great.

[StefanRijnhart]

OK, found the actual fix (after reading this PR's description, thanks!) and they warrant the whitespace changes. That leaves the question about the translation files.

[pedrobaeza]

Here there's a remaining question, so I mark for waiting this way

[NL66278]

@StefanRijnhart I looked into the translation files and they contained some wierdness before the changes, mainly having first an empty msgid "" on one line, and then the actual string on the next. So I can imagine @r-hede wanting to rectify this. But maybe he can answer this better himself.

[StefanRijnhart]

@pedrobaeza Can you confirm that translation files should be left to the weblate integration?

[r-hede]

Indeed, @NL66278 is right. I deleted the empty spaces at the beginning of many translations which seemed to me useless.

[pedrobaeza]

That's automatically done by OCA Git Bot when merging the PR, but it's not a critical problem to have it here. In the worst case, we'll have an extra commit undoing what is done here.

[StefanRijnhart]

OK, then it's allright!