Skip to content

[12.0][FIX] excel_import_export - #1612

Closed
kittiu wants to merge 1 commit into
OCA:12.0from
ecosoft-odoo:12.0-fix-excel_import_export-download_sample
Closed

[12.0][FIX] excel_import_export#1612
kittiu wants to merge 1 commit into
OCA:12.0from
ecosoft-odoo:12.0-fix-excel_import_export-download_sample

Conversation

@kittiu

@kittiu kittiu commented Jun 19, 2019

Copy link
Copy Markdown
Member

Fix Import Excel wizard, cannot download template as in v12 core Odoo prevent download default binary.

@youring

youring commented Jun 19, 2019

Copy link
Copy Markdown

Functional test OK! Thanks.

@kittiu

kittiu commented Jun 24, 2019

Copy link
Copy Markdown
Member Author

This is ready to be merged. Thanks!

Fix Import Excel wizard, cannot download template as in v12
core Odoo prevent download default binary.
@kittiu
kittiu force-pushed the 12.0-fix-excel_import_export-download_sample branch from 8799218 to 23065f3 Compare June 27, 2019 08:49
@kittiu

kittiu commented Jun 27, 2019

Copy link
Copy Markdown
Member Author

Greenified, ready to merge.

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Rebased to 12.0-ocabot-merge-pr-1612-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 5, 2019
Signed-off-by pedrobaeza
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 2862dee. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@OCA-git-bot OCA-git-bot closed this Aug 5, 2019
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (16.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants