Skip to content

[15.0][UPD] module_auto_update: enable test that got disabled - #2846

Merged
OCA-git-bot merged 1 commit into
OCA:15.0from
sunflowerit:15.0-module_auto_update-enable-test
Feb 21, 2024
Merged

[15.0][UPD] module_auto_update: enable test that got disabled#2846
OCA-git-bot merged 1 commit into
OCA:15.0from
sunflowerit:15.0-module_auto_update-enable-test

Conversation

@thomaspaulb

@thomaspaulb thomaspaulb commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

Same as #2843

@thomaspaulb
thomaspaulb force-pushed the 15.0-module_auto_update-enable-test branch from c349524 to b4e3e6d Compare February 14, 2024 15:12
@thomaspaulb

Copy link
Copy Markdown
Contributor Author

@sbidoul This runboat fail persists after retriggering, and I don't see any recent commits on 15.0 that would have broken this since a few days ago when I merged a 15.0 PR.

Arguably pyopenssl needs an update, but how could this have broken? And if it is, would this happen in other repos as well?

@sbidoul

sbidoul commented Feb 14, 2024

Copy link
Copy Markdown
Member

@thomaspaulb that's always this same story of compatibility of the latest cryptography with the old pyopenssl version that is installed by default.

The oca-ci image preinstall odoo's requirements.txt.
This one has cryptography==2.6.1 and pyopenssl==19.0.0, both pretty old.

Now, very likely, some external dependency of this repo require a more recent version of cryptography (for instance there is acme which requires cryptography>=3.2.1). So we see in the log that pip installs (correctly) cryptography 42. And that version is incompatible with pyopenssl 19.

The best solution I can think of now is to find the addon here that pulls acme and add, say, pyopenssl>19 to its external dependencies, with a comment explaining it is to force pulling a more recent pyopenssl than the default one from Odoo for compatibility with cryptography that is an indirect dependency (yeah, it's complicated). This should force pip to find a correct solution.

@thomaspaulb
thomaspaulb force-pushed the 15.0-module_auto_update-enable-test branch from 82fb765 to 8a9dc03 Compare February 20, 2024 22:04
@thomaspaulb
thomaspaulb force-pushed the 15.0-module_auto_update-enable-test branch from 8a9dc03 to 04fc3f8 Compare February 20, 2024 22:06
@thomaspaulb

Copy link
Copy Markdown
Contributor Author

Thanks, @sbidoul. I see in 14.0 they have solved by pinning cryptography to <23.2.0, and here in 15.0 someone else pinned acme<2.0.0, and I guess your trick would work as well. It seems to build now.

@thomaspaulb

Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2846-by-thomaspaulb-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit aeca16a into OCA:15.0 Feb 21, 2024
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 4c79dc0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants