Upgrade Gravatar module to v9, make installable, and add tests - #338
Merged
Conversation
|
👍 Tested on runbot. |
|
|
||
| @mock.patch('%s.urllib2' % MODULE_LOCATION) | ||
| def test_get_gravatar_base64_opens_correct_uri(self, mk, ): | ||
| ''' Test that gravatar is pinged for image ''' |
Member
There was a problem hiding this comment.
Use double quote (""") for docstring
Contributor
Author
|
Thanks for the review @danimaribeiro & @pedrobaeza - changes made per suggestions |
lasley
force-pushed
the
9.0-upgrade-gravatar
branch
from
April 4, 2016 15:43
c9dae44 to
731c787
Compare
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi All!
This PR removes deprecated
api.onein the Gravatar module, adds tests, and a few styling changes in the ReadMe.Not sure how to get Transifex to pass. I tried signing up, but it's still complaining so I ignored it.