Skip to content

[19.0][MIG] base_write_diff: Migration to 19.0 - #3467

Merged
OCA-git-bot merged 5 commits into
OCA:19.0from
camptocamp:19.0-mig-base_write_diff
Jun 30, 2026
Merged

[19.0][MIG] base_write_diff: Migration to 19.0#3467
OCA-git-bot merged 5 commits into
OCA:19.0from
camptocamp:19.0-mig-base_write_diff

Conversation

@yankinmax

@yankinmax yankinmax commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@yankinmax
yankinmax force-pushed the 19.0-mig-base_write_diff branch from d073bff to 1dfc1e1 Compare December 12, 2025 11:48
@yankinmax yankinmax changed the title [19.0][MIG] base_write_diff: Migration to 19.0 [19.0][MIG] base_write_diff: Migration to 19.0 Dec 12, 2025
@yankinmax
yankinmax force-pushed the 19.0-mig-base_write_diff branch from 1dfc1e1 to c9735a8 Compare December 12, 2025 11:52
@OCA-git-bot

OCA-git-bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BhaveshHeliconia
BhaveshHeliconia reviewed Jun 5, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use BaseCommon instead of TransactionCase? In that case, there would be no need to redefine DISABLED_MAIL_CONTEXT.

Comment thread base_write_diff/tests/test_base_write_diff.py
from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT


class TestRecordDiffCommon(TransactionCase):

@BhaveshHeliconia BhaveshHeliconia Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class TestRecordDiffCommon(TransactionCase):
class TestRecordDiffCommon(Basecommon):

Comment thread base_write_diff/tests/test_base_write_diff.py
def setUpClass(cls):
super().setUpClass()
# Setup env
cls.env = cls.env["base"].with_context(**DISABLED_MAIL_CONTEXT).env

@BhaveshHeliconia BhaveshHeliconia Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cls.env = cls.env["base"].with_context(**DISABLED_MAIL_CONTEXT).env

@ivantodorovich

ivantodorovich commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Could we use BaseCommon instead of TransactionCase? In that case, there would be no need to redefine DISABLED_MAIL_CONTEXT.

tbh, BaseCommon is doing more than what we need so I see no problem in simply setting the DISABLED_MAIL_CONTEXT in context for a raw TransactionCase.

BhaveshHeliconia
BhaveshHeliconia approved these changes Jun 8, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivantodorovich

ivantodorovich commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hello @OCA/tools-maintainers 👋🏻

Could we merge this one please? 🙏🏻

@hbrunn

hbrunn commented Jun 30, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-3467-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit ee3e4a6 into OCA:19.0 Jun 30, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at b6b959b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@ivantodorovich ivantodorovich ivantodorovich approved these changes
@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yankinmax @OCA-git-bot @ivantodorovich @hbrunn @cyrilmanuel @BhaveshHeliconia @SilvioC2C @mymage