Skip to content

[ADD] - dbfilter_from_header: Migrated and reviewed module - #382

Merged
moylop260 merged 2 commits into
OCA:9.0from
ClearCorp-dev:9.0-dbfilter_from_header-fv
Mar 8, 2016
Merged

[ADD] - dbfilter_from_header: Migrated and reviewed module#382
moylop260 merged 2 commits into
OCA:9.0from
ClearCorp-dev:9.0-dbfilter_from_header-fv

Conversation

@fv-clearcorp

Copy link
Copy Markdown
Contributor

No description provided.

@pedrobaeza

Copy link
Copy Markdown
Member

Thanks for the contribution!

You can take the occasion to update the module to latest conventions:

@pedrobaeza pedrobaeza mentioned this pull request Mar 7, 2016
59 tasks
@hbrunn

hbrunn commented Mar 8, 2016

Copy link
Copy Markdown
Member

you should also cherry-pick 5737ebc

@ghost

ghost commented Mar 8, 2016

Copy link
Copy Markdown

@hbrunn done 👍

@hbrunn

hbrunn commented Mar 8, 2016

Copy link
Copy Markdown
Member

👍

moylop260 added a commit that referenced this pull request Mar 8, 2016
[ADD] - dbfilter_from_header: Migrated and reviewed module
@moylop260
moylop260 merged commit 46922ba into OCA:9.0 Mar 8, 2016
@hbrunn

hbrunn commented Mar 8, 2016

Copy link
Copy Markdown
Member

@moylop260 I think you merged too early. @pedrobaeza still had some open points

@pedrobaeza

Copy link
Copy Markdown
Member

Yes, they are only about form, not the module itself. @moylop260, now you have to make the PR fixing them 😜

@ghost

ghost commented Mar 8, 2016

Copy link
Copy Markdown

Changes in #383

@moylop260

Copy link
Copy Markdown
Contributor

haha

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (9.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants