Skip to content

[PORT][9.0] base multi image - #402

Merged
pedrobaeza merged 15 commits into
OCA:9.0from
sodexis:9.0_base_multi_image
Mar 31, 2016
Merged

[PORT][9.0] base multi image#402
pedrobaeza merged 15 commits into
OCA:9.0from
sodexis:9.0_base_multi_image

Conversation

@SodexisTeam

Copy link
Copy Markdown
Member

cc @yajo

@pedrobaeza

Copy link
Copy Markdown
Member

Please don't lose commit history. You have to follow this procedure: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-5.6%) to 62.374% when pulling 4126fda on sodexis:9.0_base_multi_image into 632ce98 on OCA:9.0.

@pedrobaeza

Copy link
Copy Markdown
Member

The git commit message should contain [MIG] instead of [PORT]

@atchuthan
atchuthan force-pushed the 9.0_base_multi_image branch from 4126fda to 2dfec51 Compare March 30, 2016 11:58
@atchuthan

Copy link
Copy Markdown
Member

@pedrobaeza changes done

@pedrobaeza

Copy link
Copy Markdown
Member

For information, relevant commit is 2dfec51

Comment thread base_multi_image/views/image_view.xml Outdated
<field name="name">Multi images</field>
<field name="res_model">base_multi_image.image</field>
<field name="view_mode">kanban,tree,form</field>
<field name="help">Click to add multiple image</field>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to put "Click to add an image attached to an specific record."

@pedrobaeza

Copy link
Copy Markdown
Member

Little remark, but overall 👍 (code review)

@atchuthan
atchuthan force-pushed the 9.0_base_multi_image branch from 2dfec51 to bc3a87b Compare March 30, 2016 12:06
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-5.6%) to 62.374% when pulling bc3a87b on sodexis:9.0_base_multi_image into 632ce98 on OCA:9.0.

@elicoidal

Copy link
Copy Markdown

👍

@atchuthan

Copy link
Copy Markdown
Member

@pedrobaeza Please add "needs review" label for this PR

@yajo

yajo commented Mar 31, 2016

Copy link
Copy Markdown
Member

Cool thanks 👍

@hbrunn hbrunn added this to the 9.0 milestone Mar 31, 2016
@pedrobaeza
pedrobaeza merged commit a33cb4a into OCA:9.0 Mar 31, 2016
@pedrobaeza pedrobaeza mentioned this pull request Mar 31, 2016
59 tasks
@atchuthan
atchuthan deleted the 9.0_base_multi_image branch March 31, 2016 07:35
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants