[PORT] [9.0] configuration helper - #411
Merged
Merged
Conversation
Member
Author
|
@bealdav Could you review this ? |
| # You should have received a copy of the GNU Affero General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ############################################################################## |
2 tasks
yvaucher
force-pushed
the
9.0-configuration_helper
branch
2 times, most recently
from
April 8, 2016 14:00
5bc9da9 to
2d3e75a
Compare
yvaucher
force-pushed
the
9.0-configuration_helper
branch
from
April 8, 2016 14:12
2d3e75a to
05460e3
Compare
| _name = 'whatiwant.config.settings' | ||
| # fields must be defined in ResCompany class | ||
| # related fields are automatically generated from previous definitions | ||
| _companyObject = ResCompany |
Member
There was a problem hiding this comment.
missing:
# all prefixed field with _prefix in res.company, will be available in 'whatiwant.config.settings' model
_prefix = 'prefixyouchoose_'
Member
|
Nice job increasing reliability of this module: test + code shorter |
|
|
||
| * David BEAL <david.beal@akretion.com> | ||
| * Sébastien BEAU <sebastien.beau@akretion.com> | ||
| * Yannick Vaucher, Camptocamp, (code refactoring from his module 'delivery_carrier_label_postlogistics') |
Member
There was a problem hiding this comment.
please @yvaucher move your line in first position, it's more than a port: test, etc.
Port to API 8.0 and make it compatible with a config definition in API 8.0. Remove some hacks with onchange and write to get and set the related values.
yvaucher
force-pushed
the
9.0-configuration_helper
branch
from
May 3, 2016 15:43
05460e3 to
b7fdbb1
Compare
Member
Author
|
@bealdav Thanks for the review. I made the changes. |
Member
|
👍 |
| _prefix = 'setting_' | ||
| # this is the class name to import in your module | ||
| # (it should be ResCompany or res_company, depends of your code) | ||
| _companyObject = None |
Member
There was a problem hiding this comment.
Ok, it was already there, so at least only to keep compatibility.
Member
There was a problem hiding this comment.
You can break compatibility here to become cleaner, no problem between versions.
There was no version for V8, only v7.
Member
|
👍 |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port to API 8.0 and make it compatible with a config definition in API
8.0. Remove some hacks with onchange and write to get and set the
related values.