[9.0][MIG][auth_signup_verify_email] Migration. by yajo · Pull Request #436 · OCA/server-tools

yajo · 2016-05-26T14:55:57Z

Migrate to v9.

coveralls · 2016-05-27T07:55:37Z

Coverage decreased (-1.8%) to 71.267% when pulling bdbe60c on Tecnativa:9.0-auth_signup_verify_email-migration into c6deb6e on OCA:9.0.

Migrate to v9.

pedrobaeza · 2016-05-27T07:59:38Z

Is there any chance to increase test coverage?

coveralls · 2016-05-27T08:05:11Z

Coverage decreased (-1.8%) to 71.267% when pulling 33a156d on Tecnativa:9.0-auth_signup_verify_email-migration into c6deb6e on OCA:9.0.

yajo · 2016-05-27T08:08:05Z

Let me try

yajo · 2016-05-27T11:50:10Z

It's being tested now.

Is it possible that Travis is failing because it's runing in a non-CSRF mode while this test is CSRF-enabled?

moylop260 · 2016-05-27T17:14:14Z

@yajo
What change we need in server to run the tests fine?

yajo · 2016-05-30T07:53:27Z

As you see in the docs, there's built in CSRF protection for v9. My tests woked fine locally, but it seems like the csrf_token field cannot be found in the result. The most probable cause I imagine is that somehow Travis' Odoo does not have that CSRF validation enabled. Is it possible? Otherwise it makes no sense that local and runbot's tests work and Travis not. If so, it should be enabled and further tests should implement it (although mine I think is the first test in OCA that acutally needs that).

moylop260 · 2016-05-30T17:04:30Z

@yajo
I have reproduced the error locally.

I ran a travis2docker

# Create Dockerfiles
travisfile2dockerfile git@github.com:OCA/server-tools.git pull/436

# Create docker image
/tmp/script/git_github.com_oca_server-tools.git/pull_436/1ce88c2a2300653fdf1f784c088814293999d49e/3/10-build.sh --no-cache

# Create docker container
/tmp/script/git_github.com_oca_server-tools.git/pull_436/1ce88c2a2300653fdf1f784c088814293999d49e/3/20-run.sh "--name=csrf_token_error --entrypoint=bash"

# In container ran
/entrypoint.sh

After In container ran
~/odoo-9.0/odoo.py -d openerp_test -u auth_signup_verify_email --test-enable --stop-after-init

I added a pdb to debug.

diff --git a/auth_signup_verify_email/tests/test_verify_email.py b/auth_signup_verify_email/tests/test_verify_email.py
index 29ce113..e3da7a1 100644
--- a/auth_signup_verify_email/tests/test_verify_email.py
+++ b/auth_signup_verify_email/tests/test_verify_email.py
@@ -13,6 +13,7 @@ class UICase(HttpCase):
         super(UICase, self).setUp()
         settings = self.env["base.config.settings"].create({})
         settings.auth_signup_uninvited = True
+        import pdb;pdb.set_trace()
         self.data = {
             "csrf_token": self.csrf_token(),
             "name": "Somebody",

In the line

server-tools/auth_signup_verify_email/tests/test_verify_email.py(37)csrf_token() <- return doc.xpath("//input[@name='csrf_token']")[0].get("value")

I used:
import lxml;lxml.html.tostring(doc)
The result was:
<html><head><title>404 Not Found</title>\n</head><body><h1>Not Found</h1>\n<p>The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.</p>\n</body></html>

I don't know how to fix it but if this information is useful for you, Could you help me to create hypothesis to check them?

moylop260 · 2016-05-30T17:48:15Z

In other matter:
runbot don't ran the test of this module
runbot-log

...
2016-05-27 12:01:21,282 13958 INFO 3147860-436-1ce88c-all openerp.modules.loading: loading sales_team/sales_team_demo.xml
2016-05-27 12:01:21,527 13958 INFO 3147860-436-1ce88c-all openerp.modules.module: module auth_signup_verify_email: creating or updating database tables
2016-05-27 12:01:21,528 13958 INFO 3147860-436-1ce88c-all openerp.modules.loading: loading auth_signup_verify_email/views/signup.xml
# Here should be the tests
2016-05-27 12:01:21,620 13958 INFO 3147860-436-1ce88c-all openerp.modules.module: module mail_environment: creating or updating database tables

pedrobaeza · 2016-05-30T17:49:58Z

@moylop260, OCA runbot doesn't perform any test, or are you talking about your runbot?

moylop260 · 2016-05-30T17:56:06Z

@moylop260, OCA runbot doesn't perform any test, or are you talking about your runbot?

@pedrobaeza
Thank you
I did not know that

Otherwise it makes no sense that local and runbot's tests work and Travis not.

@yajo FYI runbot doesn't perform any test

moylop260 · 2016-05-30T18:28:04Z

@yajo
I have created a test-runbot using runbot_travis2docker module.

http://test.runbot.vauxoo.com/runbot/repo/git-github-com-oca-server-tools-git-2

Here you can see the error replicated.

If you give me your public ssh key I can give you ssh access to container with the error reproduced.

moylop260(at)vauxoo(dot)com

yajo · 2016-05-31T07:29:13Z

Hi, thanks for the debugging, I think I have a clue, let me see.

yajo · 2016-05-31T08:36:19Z

Test was affected by odoo/odoo#12237, it's workarounded now. Thanks!

coveralls · 2016-05-31T09:11:04Z

Coverage increased (+0.9%) to 73.988% when pulling 48842f3 on Tecnativa:9.0-auth_signup_verify_email-migration into c6deb6e on OCA:9.0.

moylop260 · 2016-05-31T12:53:25Z

Thank you @yajo

👍

carlosdauden · 2016-05-31T14:18:30Z

👍

sergio-teruel · 2016-05-31T14:38:39Z

👍

yajo · 2016-05-31T14:40:57Z

Ready to merge

* Add module auth_signup_verify_email. * Import module following guidelines. * README typos. * OCA Transbot updated translations from Transifex * Credit creator. * author name correction * [9.0][MIG][auth_signup_verify_email] Migration. Migrate to v9. * [FIX] auth_signup_verify_email: Python library requirement * Add tests, fix xml tags, fix credits. * Fix test.

Syncing from upstream OCA/server-tools (12.0)

pedrobaeza mentioned this pull request May 26, 2016

Migration to version 9.0 #271

Closed

59 tasks

yajo added 3 commits May 27, 2016 09:48

Add module auth_signup_verify_email.

3e1c84d

Import module following guidelines.

29b71b5

README typos.

41b51be

pedrobaeza force-pushed the 9.0-auth_signup_verify_email-migration branch from 5b18bd0 to bdbe60c Compare May 27, 2016 07:49

oca-transbot and others added 5 commits May 27, 2016 09:57

OCA Transbot updated translations from Transifex

5ea0130

Credit creator.

9d3db41

author name correction

b18484c

[9.0][MIG][auth_signup_verify_email] Migration.

d685999

Migrate to v9.

[FIX] auth_signup_verify_email: Python library requirement

33a156d

pedrobaeza force-pushed the 9.0-auth_signup_verify_email-migration branch from bdbe60c to 33a156d Compare May 27, 2016 07:58

yajo force-pushed the 9.0-auth_signup_verify_email-migration branch from b3560a3 to f4e549f Compare May 27, 2016 11:44

Add tests, fix xml tags, fix credits.

1ce88c2

yajo force-pushed the 9.0-auth_signup_verify_email-migration branch from f4e549f to 1ce88c2 Compare May 27, 2016 11:49

Fix test.

48842f3

moylop260 merged commit c10789a into OCA:9.0 May 31, 2016

yajo deleted the 9.0-auth_signup_verify_email-migration branch May 31, 2016 14:43

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#436 from OCA/12.0

5408203

Syncing from upstream OCA/server-tools (12.0)

Uh oh!

Uh oh!

Conversation

yajo commented May 26, 2016

Uh oh!

coveralls commented May 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented May 27, 2016

Uh oh!

coveralls commented May 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yajo commented May 27, 2016

Uh oh!

yajo commented May 27, 2016

Uh oh!

moylop260 commented May 27, 2016

Uh oh!

yajo commented May 30, 2016

Uh oh!

moylop260 commented May 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moylop260 commented May 30, 2016

Uh oh!

pedrobaeza commented May 30, 2016

Uh oh!

moylop260 commented May 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moylop260 commented May 30, 2016

Uh oh!

yajo commented May 31, 2016

Uh oh!

yajo commented May 31, 2016

Uh oh!

coveralls commented May 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moylop260 commented May 31, 2016

Uh oh!

carlosdauden commented May 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergio-teruel commented May 31, 2016

Uh oh!

yajo commented May 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

coveralls commented May 27, 2016 •

edited

Loading

coveralls commented May 27, 2016 •

edited

Loading

moylop260 commented May 30, 2016 •

edited

Loading

moylop260 commented May 30, 2016 •

edited

Loading

coveralls commented May 31, 2016 •

edited

Loading

carlosdauden commented May 31, 2016 •

edited

Loading