Skip to content

[MIG] base_report_auto_create_qweb: migration to v9 - #438

Merged
yvaucher merged 3 commits into
OCA:9.0from
damdam-s:9.0_base_report_auto_create_qweb
Jun 2, 2016
Merged

[MIG] base_report_auto_create_qweb: migration to v9#438
yvaucher merged 3 commits into
OCA:9.0from
damdam-s:9.0_base_report_auto_create_qweb

Conversation

@damdam-s

@damdam-s damdam-s commented Jun 1, 2016

Copy link
Copy Markdown
Member

No description provided.

@pedrobaeza pedrobaeza changed the title [MIG] migration to v9 [MIG] base_report_auto_create_qweb: migration to v9 Jun 1, 2016
@pedrobaeza pedrobaeza mentioned this pull request Jun 1, 2016
59 tasks
@coveralls

coveralls commented Jun 1, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.5%) to 72.494% when pulling 9340a59 on damdam-s:9.0_base_report_auto_create_qweb into f03cb72 on OCA:9.0.

@mdietrichc2c

Copy link
Copy Markdown
Contributor

👍

@moylop260

moylop260 commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

Could you check the beta pylint-odoo messages?

@moylop260

Copy link
Copy Markdown
Contributor

By example:
base_report_auto_create_qweb/views/report_xml_view.xml show a diff in all lines because you are using tabs instead of the original spaces

A future PR will change tabs to spaces creating a big diff again and create us a difficult code revision.

By that now we have the following check:
base_report_auto_create_qweb/__init__.py:1: [W7910(wrong-tabs-instead-of-spaces), ] views/report_xml_view.xml:3 Use wrong tabs indentation instead of four spaces

@elicoidal

Copy link
Copy Markdown

Hi @damdam-s Thanks for your contribution!
Could you please update the README to latest template (https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst) and copyright notices to the short type (https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py#L3)?

@coveralls

coveralls commented Jun 2, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.5%) to 72.525% when pulling cf079a8 on damdam-s:9.0_base_report_auto_create_qweb into f03cb72 on OCA:9.0.

@damdam-s
damdam-s force-pushed the 9.0_base_report_auto_create_qweb branch from cf079a8 to d52a1d7 Compare June 2, 2016 07:32
@coveralls

coveralls commented Jun 2, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.5%) to 72.525% when pulling d52a1d7 on damdam-s:9.0_base_report_auto_create_qweb into f03cb72 on OCA:9.0.

@damdam-s

damdam-s commented Jun 2, 2016

Copy link
Copy Markdown
Member Author

@moylop260 @elicoidal Lint fixed and files updated

@gurneyalex

Copy link
Copy Markdown
Member

👍

1 similar comment
@elicoidal

Copy link
Copy Markdown

👍

# -*- coding: utf-8 -*-
##############################################################################
# For copyright and license notices, see __openerp__.py file in root directory
##############################################################################

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to change it as well ?

@damdam-s
damdam-s force-pushed the 9.0_base_report_auto_create_qweb branch from d52a1d7 to 1ab28a2 Compare June 2, 2016 09:14
@coveralls

coveralls commented Jun 2, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.5%) to 72.525% when pulling 1ab28a2 on damdam-s:9.0_base_report_auto_create_qweb into f03cb72 on OCA:9.0.

@damdam-s

damdam-s commented Jun 2, 2016

Copy link
Copy Markdown
Member Author

@yvaucher fixed

@damdam-s

damdam-s commented Jun 2, 2016

Copy link
Copy Markdown
Member Author

@guewen @pedrobaeza @OSguard 3 thumbs up. can it be merged quickly ?

@yvaucher

yvaucher commented Jun 2, 2016

Copy link
Copy Markdown
Member

👍

@yvaucher
yvaucher merged commit b50802b into OCA:9.0 Jun 2, 2016
@damdam-s

damdam-s commented Jun 2, 2016

Copy link
Copy Markdown
Member Author

thanks @yvaucher

@coveralls

coveralls commented Jun 2, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.5%) to 72.525% when pulling 3b546e7 on damdam-s:9.0_base_report_auto_create_qweb into f03cb72 on OCA:9.0.

@moylop260

Copy link
Copy Markdown
Contributor

Thank you!

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants