[9.0][MIG] auth_from_http_remote_user - #457
Merged
pedrobaeza merged 4 commits intoOct 24, 2016
Merged
Conversation
lmignon
changed the title
lmignon
force-pushed
the
9.0-auth_from_http_remote_user-migration-lmi
branch
from
June 15, 2016 14:58
01d06a9 to
6963601
Compare
Member
|
The DEBUG logging mentioned in the README is not there in this version. It should be re-added or removed from the README. Otherwise 👍 (manual test and code review) |
lmignon
force-pushed
the
9.0-auth_from_http_remote_user-migration-lmi
branch
from
June 20, 2016 08:45
f471301 to
dad6bb9
Compare
Member
|
👍 |
Contributor
|
👍 auth_from_http_remote_user/tests/test_res_users.py:27: [C8104(class-camelcase), test_res_users] Use `CamelCase` "TestResUsers" in class name "test_res_users". You can use oca-autopep8 of https://github.com/OCA/maintainer-tools to auto fix it. |
lmignon
force-pushed
the
9.0-auth_from_http_remote_user-migration-lmi
branch
from
June 22, 2016 06:00
dad6bb9 to
5ce6bac
Compare
Contributor
Author
|
good catch @moylop260 . Change done. |
Member
|
The runbot error was fixed in #464 so I think we can merge. |
Contributor
Author
|
@pedrobaeza This one is ready to merge.... |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (11.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from 8.0