[MIG] base_technical_features -> 10.0 - #568
Merged
pedrobaeza merged 3 commits intoOct 12, 2016
Merged
Conversation
alexis-via
approved these changes
Oct 11, 2016
alexis-via
left a comment
alexis-via
left a comment
Contributor
There was a problem hiding this comment.
Please update version in manifest and in runbot URL and fix flake8 (remove api in import of basemodel_monkeypatch.py
StefanRijnhart
force-pushed
the
10.0-base_technical_features
branch
from
October 11, 2016 20:49
cddbbfe to
2e40ef6
Compare
Member
Author
|
@alexis-via thanks for the review! All done. |
sbidoul
reviewed
Oct 11, 2016
| models.BaseModel.user_has_groups = user_has_groups | ||
|
|
||
| return super(BaseModelMonkeyPatch, self)._register_hook(cr) | ||
| return super(BaseModelMonkeyPatch, self)._register_hook() |
Member
There was a problem hiding this comment.
@StefanRijnhart I'm no expert in these matter but is there not now a way in 10 to extend BaseModel without resorting to a monkey patch?
Member
Author
There was a problem hiding this comment.
Yes, there is, thanks for the hint! It was implemented in https://github.com/odoo/odoo/pull/10288/files. Fixed in e9ad484
legalsylvain
approved these changes
Oct 11, 2016
sbidoul
approved these changes
Oct 12, 2016
pedrobaeza
approved these changes
Oct 12, 2016
sebalix
approved these changes
Oct 12, 2016
StefanRijnhart
added a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Oct 5, 2017
[MIG] base_technical_features -> 10.0 Using new base model inheritance
TDu
pushed a commit
to TDu/server-tools
that referenced
this pull request
Nov 13, 2017
[MIG] base_technical_features -> 10.0 Using new base model inheritance
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.