[9.0] [MIG] html_image_url_extractor module - #624
Merged
Conversation
* [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.
* Updated README.rst
pedrobaeza
approved these changes
Nov 28, 2016
lasley
reviewed
Nov 29, 2016
| :param bool fail: | ||
| If ``True``, exceptions will be raised. | ||
| """ | ||
| # Parse HTML |
Contributor
There was a problem hiding this comment.
Parsing HTML with Regex is never really the way to go, please see this famous answer on SO for an amazing elaboration.
Why not just xml.dom.minidom.parseString(html).getElementsByTagName('img') + other logic?
Member
There was a problem hiding this comment.
This is only a migration of something done on v8. As this extract utility is very specific, I wouldn't touch this too much...
Contributor
There was a problem hiding this comment.
But when we bring something into OCA aren't we guaranteeing that it works by OCA standards? This definitely does not work in all instances - I've been burned by this before.
Member
There was a problem hiding this comment.
Why is not working? It's in v8 and used by many modules without problems
Contributor
There was a problem hiding this comment.
Alright wait maybe I'm misinterpreting something here. The regex is being applied against an element node, so we're good. My bad I misread there.
lasley
approved these changes
Nov 29, 2016
lasley
left a comment
lasley
left a comment
Contributor
There was a problem hiding this comment.
In light of inline convo, this was a stupid me situation. LGTM! 👍
yajo
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Jun 22, 2017
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
yajo
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Jul 17, 2017
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
tarteo
pushed a commit
to tarteo/server-tools
that referenced
this pull request
Feb 14, 2018
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
MrFangD
pushed a commit
to MrFangD/server-tools
that referenced
this pull request
Nov 3, 2018
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
cristinamartinrod
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Feb 12, 2019
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
tarteo
pushed a commit
to tarteo/server-tools
that referenced
this pull request
Jan 9, 2020
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
victoralmau
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Feb 24, 2021
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
victoralmau
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Mar 15, 2021
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
ThomasBinsfeld
pushed a commit
to acsone/server-tools
that referenced
this pull request
Mar 23, 2021
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
hkapatel-initos
pushed a commit
to initOS/server-tools
that referenced
this pull request
Jul 2, 2021
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
mtelahun
pushed a commit
to mtelahun/server-tools
that referenced
this pull request
Sep 5, 2022
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
victoralmau
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Feb 27, 2023
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst OCA Transbot updated translations from Transifex
adasatorres
pushed a commit
to adasatorres/server-tools
that referenced
this pull request
Aug 3, 2023
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (13.0)
kaynnan
pushed a commit
to Escodoo/server-tools
that referenced
this pull request
Jul 11, 2025
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst OCA Transbot updated translations from Transifex
kaynnan
pushed a commit
to Escodoo/server-tools
that referenced
this pull request
Aug 21, 2025
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst OCA Transbot updated translations from Transifex
WesleyOliveira98
pushed a commit
to Escodoo/server-tools
that referenced
this pull request
Feb 25, 2026
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst OCA Transbot updated translations from Transifex
WesleyOliveira98
pushed a commit
to Escodoo/server-tools
that referenced
this pull request
Feb 25, 2026
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst OCA Transbot updated translations from Transifex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tecnativa