Skip to content

[10.0][MIG] Module Prototyper - #634

Merged
lasley merged 9 commits into
OCA:10.0from
tarteo:100_mig_module_prototyper
Dec 20, 2016
Merged

[10.0][MIG] Module Prototyper#634
lasley merged 9 commits into
OCA:10.0from
tarteo:100_mig_module_prototyper

Conversation

@tarteo

@tarteo tarteo commented Dec 5, 2016

Copy link
Copy Markdown
Member

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request Dec 5, 2016
Closed
63 tasks
max3903
max3903 requested changes Dec 5, 2016
View reviewed changes

@max3903 max3903 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No test.

Comment thread module_prototyper/__manifest__.py Outdated
'name': 'Module Prototyper',
'version': '9.0.0.1.0',
'author': 'Savoir-faire Linux, Odoo Community Association (OCA), Sudokeys',
'version': '10.0.0.1.0',

@max3903 max3903 Dec 5, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 10.0.1.0.0

moylop260
moylop260 reviewed Dec 6, 2016
View reviewed changes
Comment thread module_prototyper/data/README.rst
Module name
===========
==============
{module_title}

@moylop260 moylop260 Dec 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real name

@sebalix sebalix Dec 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moylop260 : this README is a template, no change is required here

@moylop260 moylop260 Dec 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad
Sorry forget it

moylop260
moylop260 reviewed Dec 6, 2016
View reviewed changes
Comment thread module_prototyper/models/module_prototyper.py Outdated
'__openerp__.py',
'__openerp__.py.template',
fn_inc_ext ,
'{}.template'.format(fn_inc_ext),

@moylop260 moylop260 Dec 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u'{}.template''.format...
To avoid a ascii error similar to OCA/manufacture#146

Or apply %()s:
https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#idioms
Prefer % over .format(), prefer %(varname) instead of positional. This is better for translation and clarity.

moylop260
moylop260 reviewed Dec 6, 2016
View reviewed changes
Comment thread module_prototyper/models/module_prototyper_api_version.py Outdated
_name = 'module_prototyper.api_version'

name = fields.Char(
string='Name'

@moylop260 moylop260 Dec 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the technical name of the field (the variable name) is the same to the string of the label, don't put string parameter for new API fields, because it's automatically taken. If your variable name contains "_" in the name, they are converted to spaces when creating the automatic string and each word is capitalized. (example: old api 'name': fields.char('Name', ...) new api 'name': fields.Char(...))
https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#fields

moylop260
moylop260 approved these changes Dec 6, 2016
View reviewed changes

@moylop260 moylop260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small changes

@tarteo

tarteo commented Dec 7, 2016

Copy link
Copy Markdown
Member Author

@moylop260 Thanks for your feedback, really helpful! But the first comment "Real name" I don't quite understand. Can you explain this to me, please?

@lasley
lasley merged commit 4271241 into OCA:10.0 Dec 20, 2016
sebalix pushed a commit to osiell/server-tools that referenced this pull request Jan 23, 2017
Dennis Sluijk @sebalix
[10.0][MIG] Module Prototyper (OCA#634)
4d61f08 
* [ADD] Updated manifest and README

* [ADD] Version 10.0 template and api_version model

* [ADD] Updated license header, updated api call

* [FIX] Flake

* [FIX] Flake

* [FIX] Tests

* [FIX] Flake8

* [ADD] Extra test for changed method 'set_jinja_env'

* [FIX] Fixed 'Try me on runbot' button
njeudy pushed a commit to njeudy/server-tools that referenced this pull request Nov 5, 2019
Dennis Sluijk @njeudy
[10.0][MIG] Module Prototyper (OCA#634)
0bdb807 
* [ADD] Updated manifest and README

* [ADD] Version 10.0 template and api_version model

* [ADD] Updated license header, updated api call

* [FIX] Flake

* [FIX] Flake

* [FIX] Tests

* [FIX] Flake8

* [ADD] Extra test for changed method 'set_jinja_env'

* [FIX] Fixed 'Try me on runbot' button
njeudy pushed a commit to njeudy/server-tools that referenced this pull request Nov 5, 2019
Dennis Sluijk @njeudy
[10.0][MIG] Module Prototyper (OCA#634)
85e7bd3 
* [ADD] Updated manifest and README

* [ADD] Version 10.0 template and api_version model

* [ADD] Updated license header, updated api call

* [FIX] Flake

* [FIX] Flake

* [FIX] Tests

* [FIX] Flake8

* [ADD] Extra test for changed method 'set_jinja_env'

* [FIX] Fixed 'Try me on runbot' button
dsolanki-initos pushed a commit to initOS/server-tools that referenced this pull request Apr 23, 2021
Dennis Sluijk @dsolanki-initos
[10.0][MIG] Module Prototyper (OCA#634)
7b081cd 
* [ADD] Updated manifest and README

* [ADD] Version 10.0 template and api_version model

* [ADD] Updated license header, updated api call

* [FIX] Flake

* [FIX] Flake

* [FIX] Tests

* [FIX] Flake8

* [ADD] Extra test for changed method 'set_jinja_env'

* [FIX] Fixed 'Try me on runbot' button
dsolanki-initos pushed a commit to initOS/server-tools that referenced this pull request Apr 23, 2021
Dennis Sluijk @dsolanki-initos
[10.0][MIG] Module Prototyper (OCA#634)
e63aa81 
* [ADD] Updated manifest and README

* [ADD] Version 10.0 template and api_version model

* [ADD] Updated license header, updated api call

* [FIX] Flake

* [FIX] Flake

* [FIX] Tests

* [FIX] Flake8

* [ADD] Extra test for changed method 'set_jinja_env'

* [FIX] Fixed 'Try me on runbot' button
hkapatel-initos pushed a commit to initOS/server-tools that referenced this pull request Sep 10, 2021
Dennis Sluijk @hkapatel-initos
[10.0][MIG] Module Prototyper (OCA#634)
8a43d2f 
* [ADD] Updated manifest and README

* [ADD] Version 10.0 template and api_version model

* [ADD] Updated license header, updated api call

* [FIX] Flake

* [FIX] Flake

* [FIX] Tests

* [FIX] Flake8

* [ADD] Extra test for changed method 'set_jinja_env'

* [FIX] Fixed 'Try me on runbot' button
mtelahun pushed a commit to mtelahun/server-tools that referenced this pull request Sep 5, 2022
Dennis Sluijk @mtelahun
[10.0][MIG] Module Prototyper (OCA#634)
1ebeb13 
* [ADD] Updated manifest and README

* [ADD] Version 10.0 template and api_version model

* [ADD] Updated license header, updated api call

* [FIX] Flake

* [FIX] Flake

* [FIX] Tests

* [FIX] Flake8

* [ADD] Extra test for changed method 'set_jinja_env'

* [FIX] Fixed 'Try me on runbot' button
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#634 from OCA/13.0
8e01801 
Syncing from upstream OCA/server-tools (13.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebalix sebalix sebalix left review comments
@moylop260 moylop260 moylop260 approved these changes
@max3903 max3903 max3903 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tarteo @max3903 @sebalix @moylop260 @lasley