[9.0][FIX] base_kanban_stage: Add group_expand attr - #716
Closed
lasley wants to merge 2 commits into
Closed
Conversation
* Add group_expand attr to abstract kanban model, allowing for empty columns * Fix `_read_group_stage_ids` for new API
lasley
force-pushed
the
bugfix/9.0/base_kanban_stage-read_group_stage_ids
branch
from
January 27, 2017 03:10
e347dc1 to
902bcc1
Compare
dreispt
approved these changes
Jan 27, 2017
Contributor
Author
|
Oops it seems I didn't update the tests - I noticed this in the v10 PR & have cherry picked here. I forget how important CI is until it goes away! I fixed the v9 build with #719 in light of this almost-whoopsie as well. |
Contributor
Author
|
Ok yup so this is irrelevant in 9, my bad. Implementation is confirmed good & I can actually remove a few more lines in the pending v10 PR. I love removing code 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix for issue described in #681 (comment):
_read_group_stage_idsfor new APIcc @dreispt @obulkin