[10.0][MIG] base_search_fuzzy - #722
Merged
Merged
Conversation
…s, added translations, added access permissions, moved the monkey patching to method _register_hook of ir.model and fixed _auto_init, added README, cleaned up some aprts
lasley
force-pushed
the
release/10.0/base_search_fuzzy
branch
from
February 1, 2017 16:59
0cbaf8a to
419c5a3
Compare
lasley
force-pushed
the
release/10.0/base_search_fuzzy
branch
from
February 1, 2017 17:11
419c5a3 to
5d0bcbb
Compare
lasley
force-pushed
the
release/10.0/base_search_fuzzy
branch
4 times, most recently
from
February 1, 2017 19:31
e0b53d8 to
4bcfcbf
Compare
lasley
force-pushed
the
release/10.0/base_search_fuzzy
branch
from
February 1, 2017 19:41
4bcfcbf to
55fc4fe
Compare
lasley
commented
Feb 4, 2017
|
|
||
| if left in model._fields: | ||
| column = '%s.%s' % (table_alias, expression._quote(left)) | ||
| query = '(%s %s %%s)' % (column, sql_operator) |
Contributor
Author
There was a problem hiding this comment.
%%s should be replaced with model._fields[left].column_format on this and ln 31
Member
There was a problem hiding this comment.
Did you review your own PR?
Contributor
Author
There was a problem hiding this comment.
Hah more of just a note to remember to make this change. I was randomly digging around in the expression code for an unrelated thing, saw column_format, and remembered this code. Making the change now!
StefanRijnhart
approved these changes
Feb 21, 2017
StefanRijnhart
left a comment
StefanRijnhart
left a comment
Member
There was a problem hiding this comment.
Migration LGTM and tests run successfully. Thanks!
lasley
force-pushed
the
release/10.0/base_search_fuzzy
branch
from
February 21, 2017 20:45
7aac463 to
18f6a5e
Compare
Contributor
Author
|
@tedsalmon please review |
4 tasks
tedsalmon
approved these changes
Apr 10, 2017
tedsalmon
left a comment
tedsalmon
left a comment
There was a problem hiding this comment.
LGTM 👍 ! A few small review notes were left but they're likely things that existed pre-migration :)
| Bugs are tracked on `GitHub Issues | ||
| <https://github.com/OCA/server-tools/issues>`_. In case of trouble, please | ||
| check there if your issue has already been reported. If you spotted it first, | ||
| help us smashing it by providing a detailed and welcomed feedback. |
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
| import logging | ||
|
|
||
| from odoo import models, api |
| params = right | ||
| else: # Must not happen | ||
| raise ValueError( | ||
| "Invalid field %r in domain term %r" % (left, leaf)) |
There was a problem hiding this comment.
Exceptions should be internationalized, right?
Contributor
Author
|
Thanks @tedsalmon - comments attended to |
* Rename manifest * Update openerp references to odoo * Bump version * Upgrade api usages
lasley
force-pushed
the
release/10.0/base_search_fuzzy
branch
from
April 11, 2017 00:14
56a3a5b to
390a952
Compare
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
base_search_fuzzyto v10: