[MIG][10.0][html_text] Migrate - #874
Merged
Merged
Conversation
Member
|
Check Travis status |
2 tasks
chienandalu
approved these changes
Jun 27, 2017
chienandalu
left a comment
chienandalu
left a comment
Member
There was a problem hiding this comment.
Code review ok. Travis fails are just logged exceptions as expected from the tests behavior.
Member
|
Travis should be green |
Member
|
The same as the other PR |
moylop260
reviewed
Jul 3, 2017
| with self.assertRaises(TypeError): | ||
| self.text_from_html(False, fail=True) | ||
|
|
||
| def test_bad_html(self): |
Contributor
There was a problem hiding this comment.
You should use @tools.mute_logger() to silent traceback logging expected errors.
Contributor
There was a problem hiding this comment.
+ @odoo.tools.mute_logger('odoo.addons.html_text.models.ir_fields_converter')
def test_bad_html(self):Or
- with self.assertRaises(etree.ParserError):
+ with self.assertRaises(etree.ParserError), odoo.tools.mute_logger('odoo.addons.html_text.models.ir_fields_converter'):
pedrobaeza
approved these changes
Jul 14, 2017
Member
|
Please squash your commits to merge. |
* [8.0][html_text] Excerpt generator. This module adds a technical utility to allow the developer to get an excerpt from any HTML chunk. You can choose the maximum amount of words or characters if you want. See the README and inline docstrings for further details.
Member
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tecnativa